[auth-swift] Fix Component warning #12269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
paulb777
force-pushed
the
pb-fix-component-warning
branch
from
adfad04 to
2dd98ae
Compare
paulb777
force-pushed
the
pb-fix-component-warning
branch
from
2dd98ae to
998853a
Compare
paulb777
commented
Jan 13, 2024
| @@ -168,7 +168,7 @@ extension Auth: AuthInterop { | |||
| @return The `Auth` instance associated with the given app. | |||
| */ | |||
| @objc open class func auth(app: FirebaseApp) -> Auth { | |||
| return ComponentType<AuthProvider>.instance(for: AuthProvider.self, in: app.container) as! Auth | |||
| return ComponentType<AuthProvider>.instance(for: AuthProvider.self, in: app.container).auth() | |||
There was a problem hiding this comment.
Now the type can be right here, since we return an AuthComponent instead of an Auth below.
| return Auth(app: app) | ||
| let newComponent = AuthComponent(app: app) | ||
| // Set up instances early enough so User on keychain will be decoded. | ||
| newComponent.auth() |
There was a problem hiding this comment.
Without doing this priming, User will not be initialized from the keychain
|
Merging here. I'll address any comments in a subsequent PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following console log warning:
10.20.0 - [FirebaseCore][I-COR000030] An instance conforming to FIRAuthProvider was requested, but the instance provided does not conform to the protocol