[Rollouts] Implement insert and load logic for rollout metadata in RC #12262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themiswang
reviewed
Jan 11, 2024
themiswang
reviewed
Jan 11, 2024
themiswang
reviewed
Jan 11, 2024
danasilver
reviewed
Jan 12, 2024
| @@ -134,6 +140,14 @@ - (void)loadConfigFromMainTable { | |||
| self->_activePersonalization = [activePersonalization copy]; | |||
| dispatch_group_leave(self->_dispatch_group); | |||
| }]; | |||
|
|
|||
| dispatch_group_enter(_dispatch_group); | |||
There was a problem hiding this comment.
Is it possible to do this in loadMainWithBundleIdentifier? It looks like there's an existing todo above to do that for personalization, so it'd be nice if we can avoid it here
There was a problem hiding this comment.
Moved rollout metadata loading to loadMain.
themiswang
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Two more minor comment and overall LGTM! Another nit I just realized in RC for all NSArray and NSDictionary there is no type declaration for the element. In Crash we do Array<NSString *>* something like this to improve readability. Might be good to start this change from your PR and it will def help the folks outside your team to review PRs!
themiswang
reviewed
Jan 17, 2024
danasilver
approved these changes
Jan 18, 2024
karenyz
reviewed
Jan 18, 2024
karenyz
approved these changes
Jan 18, 2024
ddnan
changed the title
themiswang
pushed a commit
that referenced
this pull request
Jan 23, 2024
themiswang
pushed a commit
that referenced
this pull request
Feb 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add insertOrUpdate method to persist rollout metadata in sqlite db
Add load method to load rollout metadata from sqlite db
Note: this change will merge to our feature branch not master
#no-changelog