Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update async/await availability comments to "iOS 13+" #12261

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Update async/await availability comments to "iOS 13+" #12261

merged 2 commits into from
Jan 10, 2024

Conversation

andrewheard
Copy link
Contributor

  • Updated comments to say async/await is available on iOS 13+ (from 15+ and macOS 10.15+) since it was backported in Xcode 13.2+ / Swift 5.5.2+
  • Removed mention of Swift 5.5+ in the comments since we only support 5.6+
  • Fixed macOS 11.15 typos (version doesn't exist -- assumed 10.15 since that's the minimum for async/await)

#no-changelog

@andrewheard andrewheard requested a review from paulb777 January 10, 2024 19:03
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    Overall coverage changed from 56.83% (b880ec8) to 56.82% (9766ffc) by -0.01%.

    FilenameBase (b880ec8)Merge (9766ffc)Diff
    FSRWebSocket.m38.29%38.14%-0.15%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ciTcAekPyd.html

paulb777
paulb777 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks.

@andrewheard andrewheard merged commit 7db032c into main Jan 10, 2024
160 checks passed
@andrewheard andrewheard deleted the ah/async-await-comment branch January 10, 2024 19:38
@firebase firebase locked and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: appcheck api: core api: database api: functions api: installations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewheard @google-oss-bot @paulb777