Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Auth SwiftAPI.swift testing #12091

Merged
merged 9 commits into from
Nov 13, 2023
Merged

Align Auth SwiftAPI.swift testing #12091

merged 9 commits into from
Nov 13, 2023

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Nov 10, 2023

The changes to SwiftAPI.swift can be seen on the individual commit diffs

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

google-oss-bot commented Nov 10, 2023

Coverage Report 1

Affected Products

  • FirebaseAuth-iOS-FirebaseAuth.framework

    Overall coverage changed from 68.52% (5de0369) to 68.53% (caaf866) by +0.01%.

    FilenameBase (5de0369)Merge (caaf866)Diff
    FIRAuthKeychainServices.m58.80%59.66%+0.86%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/iSt54CUq8L.html

@paulb777 paulb777 force-pushed the pb-align-swift-api-tests branch from 16ee823 to e65b1bd Compare November 10, 2023 19:10
@paulb777 paulb777 merged commit 161fdc5 into master Nov 13, 2023
83 checks passed
@paulb777 paulb777 deleted the pb-align-swift-api-tests branch November 13, 2023 18:44
@firebase firebase locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants