Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analytics 10.17.0 RC1 #11996

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Analytics 10.17.0 RC1 #11996

merged 2 commits into from
Oct 25, 2023

Conversation

tsunghung
Copy link
Contributor

Analytics 10.17.0 RC1 #no-changelog

@tsunghung tsunghung added this to the 10.17.0 - M139 milestone Oct 24, 2023
@tsunghung tsunghung requested a review from ncooke3 October 24, 2023 23:03
ncooke3
ncooke3 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI. I'll merge it, re-tag, and stage when it's ready.

@google-oss-bot
Copy link

Size Report 1

Affected Products

  • FirebaseAnalytics

    TypeBase (7816982)Merge (a7396f9)Diff
    CocoaPods?1.59 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/F5mQn1HAaY.html

@tsunghung
Copy link
Contributor Author

tsunghung commented Oct 24, 2023 •
edited
Loading

We may have another patch. Please hold the merge.

@tsunghung
Copy link
Contributor Author

All patches are in. The PR is ready to merge, thanks.

@paulb777 paulb777 merged commit 8872dbd into master Oct 25, 2023
42 checks passed
@paulb777 paulb777 deleted the analytics-10.17.0-rc1 branch October 25, 2023 03:38
@firebase firebase locked and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
api: analytics
Projects
None yet
Milestone
10.17.0 - M139
Development

Successfully merging this pull request may close these issues.
4 participants
@tsunghung @google-oss-bot @ncooke3 @paulb777