Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Firestore] Follow-up review items from #11954 #11970

Merged
merged 6 commits into from
Oct 20, 2023
Merged

[Firestore] Follow-up review items from #11954 #11970

merged 6 commits into from
Oct 20, 2023

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Oct 19, 2023

Meant to include these in #11954. They don't affect pod spec staging and aren't release critical.

#no-changelog

@ncooke3 ncooke3 enabled auto-merge (squash) October 19, 2023 23:56
paulb777
paulb777 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on green

@google-oss-bot
Copy link

google-oss-bot commented Oct 20, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    Overall coverage changed from ? (3e4b721) to 56.83% (96b97a7) by ?.

    105 individual files with coverage change

    FilenameBase (3e4b721)Merge (96b97a7)Diff
    APLevelDB.mm?61.30%?
    DatabaseReference+WriteEncodable.swift?0.00%?
    DataSnapshot+ReadDecodable.swift?0.00%?
    FAckUserWrite.m?83.33%?
    FArraySortedDictionary.m?97.49%?
    FAtomicNumber.m?100.00%?
    fbase64.c?32.00%?
    FCacheNode.m?100.00%?
    FCachePolicy.m?17.14%?
    FCancelEvent.m?0.00%?
    FChange.m?88.24%?
    FChildChangeAccumulator.m?65.22%?
    FChildEventRegistration.m?0.00%?
    FChildrenNode.m?91.16%?
    FClock.m?100.00%?
    FCompoundHash.m?97.70%?
    FCompoundWrite.m?91.12%?
    FConnection.m?26.81%?
    FDataEvent.m?29.41%?
    FEmptyNode.m?100.00%?
    FEventEmitter.m?0.00%?
    FEventGenerator.m?95.37%?
    FEventRaiser.m?33.33%?
    FImmutableSortedDictionary.m?31.03%?
    FImmutableSortedSet.m?54.22%?
    FImmutableTree.m?85.75%?
    FIndex.m?91.67%?
    FIndexedFilter.m?96.38%?
    FIndexedNode.m?97.06%?
    FIRDatabase.m?15.76%?
    FIRDatabaseComponent.m?19.23%?
    FIRDatabaseConfig.m?59.62%?
    FIRDatabaseConnectionContextProvider.m?96.67%?
    FIRDatabaseQuery.m?3.86%?
    FIRDatabaseReference.m?6.41%?
    FIRDataSnapshot.m?89.71%?
    FIRMutableData.m?75.51%?
    FIRRetryHelper.m?83.33%?
    FIRServerValue.m?0.00%?
    FIRTransactionResult.m?0.00%?
    FKeepSyncedEventRegistration.m?0.00%?
    FKeyIndex.m?60.56%?
    FLeafNode.m?86.98%?
    FLevelDBStorageEngine.m?71.40%?
    FLimitedFilter.m?97.25%?
    FListenComplete.m?0.00%?
    FLLRBEmptyNode.m?75.00%?
    FLLRBValueNode.m?85.39%?
    FMaxNode.m?60.61%?
    FMerge.m?87.18%?
    FNamedNode.m?62.32%?
    FNextPushId.m?62.50%?
    FOperationSource.m?89.29%?
    FOverwrite.m?81.48%?
    FPath.m?94.30%?
    FPathIndex.m?88.75%?
    FPendingPut.m?0.00%?
    FPersistenceManager.m?55.19%?
    FPersistentConnection.m?21.26%?
    FPriorityIndex.m?87.84%?
    FPruneForest.m?93.08%?
    FQueryParams.m?96.24%?
    FQuerySpec.m?86.36%?
    FRangedFilter.m?93.67%?
    FRangeMerge.m?94.06%?
    FRepo.m?13.48%?
    FRepoInfo.m?73.00%?
    FRepoManager.m?29.86%?
    FServerValues.m?50.85%?
    FSnapshotHolder.m?100.00%?
    FSnapshotUtilities.m?62.06%?
    FSparseSnapshotTree.m?98.13%?
    FSRWebSocket.m?38.29%?
    FStringUtilities.m?79.41%?
    FSyncPoint.m?87.80%?
    FSyncTree.m?71.33%?
    FTrackedQuery.m?75.38%?
    FTrackedQueryManager.m?90.50%?
    FTransformedEnumerator.m?100.00%?
    FTree.m?6.04%?
    FTreeNode.m?100.00%?
    FTreeSortedDictionary.m?96.17%?
    FTreeSortedDictionaryEnumerator.m?100.00%?
    FTupleNodePath.m?0.00%?
    FTupleObjectNode.m?0.00%?
    FTuplePathValue.m?100.00%?
    FTupleRemovedQueriesEvents.m?100.00%?
    FTupleSetIdPath.m?0.00%?
    FTupleStringNode.m?0.00%?
    FTupleTransaction.m?0.00%?
    FTupleUserCallback.m?0.00%?
    FUtilities.m?74.01%?
    FValidation.m?25.32%?
    FValueEventRegistration.m?0.00%?
    FValueIndex.m?48.53%?
    FView.m?80.11%?
    FViewCache.m?100.00%?
    FViewProcessor.m?91.87%?
    FViewProcessorResult.m?100.00%?
    FWebSocketConnection.m?41.74%?
    FWriteRecord.m?45.65%?
    FWriteTree.m?75.44%?
    FWriteTreeRef.m?100.00%?
    NSData+SRB64Additions.m?81.82%?
    ServerTimestamp.swift?0.00%?

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from ? (3e4b721) to 40.71% (96b97a7) by ?.

    23 individual files with coverage change

    FilenameBase (3e4b721)Merge (96b97a7)Diff
    CodablePassThroughTypes.swift?100.00%?
    CollectionReference+AsyncAwait.swift?96.88%?
    CollectionReference+WriteEncodable.swift?100.00%?
    DocumentID.swift?86.44%?
    DocumentReference+Codable.swift?50.00%?
    DocumentReference+ReadDecodable.swift?0.00%?
    DocumentReference+WriteEncodable.swift?100.00%?
    DocumentSnapshot+ReadDecodable.swift?80.00%?
    EncoderDecoder.swift?100.00%?
    ExplicitNull.swift?90.48%?
    FieldValue+Encodable.swift?100.00%?
    Firestore+AsyncAwait.swift?97.75%?
    FirestoreQuery.swift?0.00%?
    FirestoreQueryObservable.swift?0.00%?
    GeoPoint+Codable.swift?100.00%?
    QueryPredicate.swift?0.00%?
    ServerTimestamp.swift?96.97%?
    SwiftHeaderWorkaround.swift?0.00%?
    Timestamp+Codable.swift?100.00%?
    TimestampDecodingStrategy.swift?100.00%?
    TimestampEncodingStrategy.swift?100.00%?
    Transaction+WriteEncodable.swift?100.00%?
    WriteBatch+WriteEncodable.swift?100.00%?

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from ? (3e4b721) to 88.17% (96b97a7) by ?.

    229 individual files with coverage change

    FilenameBase (3e4b721)Merge (96b97a7)Diff
    aggregate_alias.cc?100.00%?
    aggregate_field.cc?100.00%?
    aggregate_query.cc?100.00%?
    aggregation_result.nanopb.cc?0.00%?
    any.nanopb.cc?0.00%?
    array_contains_any_filter.cc?100.00%?
    array_contains_filter.cc?100.00%?
    async_queue.cc?100.00%?
    auth_token.cc?100.00%?
    autoid.cc?100.00%?
    background_queue.cc?100.00%?
    bits.cc?100.00%?
    bloom_filter.cc?90.12%?
    bloom_filter.nanopb.cc?0.00%?
    bound.cc?84.29%?
    bundle.nanopb.cc?0.00%?
    bundle_loader.cc?95.65%?
    bundle_reader.cc?91.26%?
    bundle_serializer.cc?91.49%?
    byte_stream_apple.mm?86.36%?
    byte_stream_cpp.cc?83.33%?
    byte_string.cc?80.30%?
    collection_reference.cc?100.00%?
    common.nanopb.cc?34.48%?
    comparison.cc?100.00%?
    composite_filter.cc?90.10%?
    connectivity_monitor.cc?100.00%?
    connectivity_monitor_apple.mm?51.92%?
    converters.mm?100.00%?
    database_id.cc?65.38%?
    database_info.cc?100.00%?
    datastore.cc?96.69%?
    delete_mutation.cc?84.00%?
    direction.cc?76.92%?
    document.cc?0.00%?
    document.nanopb.cc?98.33%?
    document_change.cc?62.50%?
    document_key.cc?93.06%?
    document_key_reference.cc?65.00%?
    document_overlay_cache.cc?100.00%?
    document_reference.cc?100.00%?
    document_set.cc?87.30%?
    document_snapshot.cc?100.00%?
    empty.nanopb.cc?0.00%?
    error_apple.mm?92.31%?
    event_manager.cc?98.08%?
    exception.cc?84.21%?
    exception_apple.mm?96.55%?
    executor_libdispatch.mm?96.06%?
    executor_std.cc?97.71%?
    exponential_backoff.cc?100.00%?
    field_filter.cc?95.00%?
    field_index.cc?92.68%?
    field_mask.cc?100.00%?
    field_path.cc?98.17%?
    field_transform.cc?41.67%?
    filesystem_apple.mm?83.33%?
    filesystem_common.cc?81.67%?
    filesystem_posix.cc?81.82%?
    filter.cc?70.00%?
    FIRAggregateField.mm?98.41%?
    FIRAggregateQuery.mm?100.00%?
    FIRAggregateQuerySnapshot.mm?100.00%?
    FIRCollectionReference.mm?95.08%?
    FIRDocumentChange.mm?76.32%?
    FIRDocumentReference.mm?97.10%?
    FIRDocumentSnapshot.mm?97.89%?
    firebase_app_check_credentials_provider_apple.mm?92.93%?
    firebase_auth_credentials_provider_apple.mm?76.64%?
    firebase_metadata_provider_apple.mm?86.96%?
    firebase_metadata_provider_noop.cc?100.00%?
    firestore.cc?92.41%?
    firestore.nanopb.cc?35.95%?
    firestore_client.cc?98.94%?
    firestore_index_value_writer.cc?90.00%?
    FIRFieldPath.mm?90.24%?
    FIRFieldValue.mm?89.41%?
    FIRFilter.mm?100.00%?
    FIRFirestore.mm?89.02%?
    FIRFirestoreSettings.mm?81.00%?
    FIRFirestoreSource.mm?90.91%?
    FIRGeoPoint.mm?82.22%?
    FIRListenerRegistration.mm?100.00%?
    FIRLoadBundleTask.mm?80.70%?
    FIRLocalCacheSettings.mm?48.97%?
    FIRPersistentCacheIndexManager.mm?100.00%?
    FIRQuery.mm?87.87%?
    FIRQuerySnapshot.mm?95.45%?
    FIRSnapshotMetadata.mm?100.00%?
    FIRTimestamp.m?79.35%?
    FIRTransaction.mm?97.64%?
    FIRTransactionOptions.mm?100.00%?
    FIRWriteBatch.mm?100.00%?
    FSTFirestoreComponent.mm?95.74%?
    FSTUserDataReader.mm?95.38%?
    FSTUserDataWriter.mm?87.06%?
    geo_point.cc?65.00%?
    grpc_completion.cc?100.00%?
    grpc_connection.cc?77.50%?
    grpc_nanopb.cc?94.87%?
    grpc_root_certificate_finder_generated.cc?100.00%?
    grpc_stream.cc?99.01%?
    grpc_streaming_reader.cc?100.00%?
    grpc_unary_call.cc?100.00%?
    grpc_util.cc?100.00%?
    hard_assert.cc?100.00%?
    http.nanopb.cc?0.00%?
    index.nanopb.cc?0.00%?
    index_backfiller.cc?100.00%?
    index_entry.cc?60.00%?
    in_filter.cc?100.00%?
    json_reader.cc?87.50%?
    key_field_filter.cc?100.00%?
    key_field_in_filter.cc?100.00%?
    key_field_not_in_filter.cc?100.00%?
    latlng.nanopb.cc?86.67%?
    leveldb_bundle_cache.cc?76.00%?
    leveldb_document_overlay_cache.cc?97.17%?
    leveldb_index_manager.cc?97.73%?
    leveldb_key.cc?98.63%?
    leveldb_lru_reference_delegate.cc?95.93%?
    leveldb_migrations.cc?92.64%?
    leveldb_mutation_queue.cc?92.42%?
    leveldb_opener.cc?78.99%?
    leveldb_overlay_migration_manager.cc?100.00%?
    leveldb_persistence.cc?92.31%?
    leveldb_remote_document_cache.cc?96.55%?
    leveldb_target_cache.cc?94.68%?
    leveldb_transaction.cc?98.79%?
    leveldb_util.cc?71.43%?
    load_bundle_task.cc?97.06%?
    local_documents_view.cc?96.92%?
    local_serializer.cc?87.78%?
    local_store.cc?100.00%?
    local_view_changes.cc?100.00%?
    logic_utils.cc?97.94%?
    log_apple.mm?93.33%?
    lru_garbage_collector.cc?91.34%?
    maybe_document.nanopb.cc?28.89%?
    md5.cc?91.88%?
    memory_bundle_cache.cc?100.00%?
    memory_document_overlay_cache.cc?100.00%?
    memory_eager_reference_delegate.cc?100.00%?
    memory_index_manager.cc?51.61%?
    memory_lru_reference_delegate.cc?95.41%?
    memory_mutation_queue.cc?100.00%?
    memory_persistence.cc?97.37%?
    memory_remote_document_cache.cc?93.83%?
    memory_target_cache.cc?100.00%?
    message.cc?100.00%?
    mutable_document.cc?68.52%?
    mutation.cc?86.15%?
    mutation.nanopb.cc?75.76%?
    mutation_batch.cc?88.30%?
    mutation_batch_result.cc?52.17%?
    nanopb_util.cc?100.00%?
    not_in_filter.cc?100.00%?
    object_value.cc?100.00%?
    online_state_tracker.cc?100.00%?
    ordered_code.cc?94.39%?
    order_by.cc?50.00%?
    overlay.cc?100.00%?
    patch_mutation.cc?100.00%?
    path.cc?100.00%?
    persistent_cache_index_manager.cc?100.00%?
    precondition.cc?86.49%?
    pretty_printing.cc?83.33%?
    proto_sizer.cc?100.00%?
    query.cc?98.43%?
    query.nanopb.cc?67.92%?
    query_core.cc?95.80%?
    query_engine.cc?98.68%?
    query_listener.cc?100.00%?
    query_listener_registration.cc?100.00%?
    query_snapshot.cc?84.21%?
    reader.cc?100.00%?
    reference_set.cc?88.89%?
    remote_event.cc?97.75%?
    remote_objc_bridge.cc?92.96%?
    remote_store.cc?91.16%?
    resource.nanopb.cc?0.00%?
    resource_path.cc?100.00%?
    schedule.cc?100.00%?
    secure_random_arc4random.cc?100.00%?
    serializer.cc?91.00%?
    server_timestamp_util.cc?95.77%?
    settings.cc?83.11%?
    set_mutation.cc?89.13%?
    snapshots_in_sync_listener_registration.cc?100.00%?
    snapshot_metadata.cc?100.00%?
    snapshot_version.cc?85.71%?
    status.cc?73.05%?
    status.nanopb.cc?72.22%?
    statusor.cc?80.00%?
    status_apple.mm?96.61%?
    status_errno.cc?37.82%?
    stream.cc?98.83%?
    strerror.cc?100.00%?
    string_apple.cc?100.00%?
    string_format.cc?93.94%?
    string_util.cc?100.00%?
    struct.nanopb.cc?7.32%?
    sync_engine.cc?95.26%?
    target.cc?96.23%?
    target.nanopb.cc?45.00%?
    target_data.cc?43.04%?
    target_id_generator.cc?100.00%?
    target_index_matcher.cc?90.77%?
    task.cc?94.78%?
    testing_hooks.cc?100.00%?
    timestamp.cc?94.00%?
    timestamp.nanopb.cc?100.00%?
    timestamp_internal.cc?53.33%?
    transaction.cc?90.06%?
    transaction_runner.cc?100.00%?
    transform_operation.cc?77.03%?
    user.cc?100.00%?
    user_data.cc?96.30%?
    value_util.cc?95.71%?
    verify_mutation.cc?12.50%?
    view.cc?98.39%?
    view_snapshot.cc?78.99%?
    watch_change.cc?90.00%?
    watch_stream.cc?90.70%?
    wrappers.nanopb.cc?11.11%?
    write.nanopb.cc?60.57%?
    writer.cc?96.97%?
    write_batch.cc?91.89%?
    write_stream.cc?91.55%?

  • FirebaseFirestore-iOS-FirebaseFirestoreSwift.framework

    Overall coverage changed from ? (3e4b721) to 0.00% (96b97a7) by ?.

  • FirebaseInAppMessaging-iOS-FirebaseInAppMessaging.framework

    Overall coverage changed from ? (3e4b721) to 44.72% (96b97a7) by ?.

    45 individual files with coverage change

    FilenameBase (3e4b721)Merge (96b97a7)Diff
    CustomInAppMessageDisplayViewModifier.swift?0.00%?
    FIRIAMActionURLFollower.m?52.78%?
    FIRIAMActivityLogger.m?60.96%?
    FIRIAMAnalyticsEventLoggerImpl.m?60.71%?
    FIRIAMBannerViewController.m?0.00%?
    FIRIAMBannerViewUIWindow.m?0.00%?
    FIRIAMBaseRenderingViewController.m?0.00%?
    FIRIAMBookKeeper.m?88.41%?
    FIRIAMCardViewController.m?0.00%?
    FIRIAMClearcutHttpRequestSender.m?0.00%?
    FIRIAMClearcutLogger.m?62.50%?
    FIRIAMClearcutLogStorage.m?62.50%?
    FIRIAMClearcutUploader.m?90.34%?
    FIRIAMClientInfoFetcher.m?61.98%?
    FIRIAMDefaultDisplayImpl.m?1.78%?
    FIRIAMDisplayCheckOnAnalyticEventsFlow.m?0.00%?
    FIRIAMDisplayCheckOnAppForegroundFlow.m?0.00%?
    FIRIAMDisplayCheckOnFetchDoneNotificationFlow.m?0.00%?
    FIRIAMDisplayCheckTriggerFlow.m?0.00%?
    FIRIAMDisplayExecutor.m?66.96%?
    FIRIAMDisplayTriggerDefinition.m?68.42%?
    FIRIAMElapsedTimeTracker.m?92.31%?
    FIRIAMFetchFlow.m?80.35%?
    FIRIAMFetchOnAppForegroundFlow.m?0.00%?
    FIRIAMFetchResponseParser.m?86.11%?
    FIRIAMImageOnlyViewController.m?0.00%?
    FIRIAMMessageClientCache.m?78.11%?
    FIRIAMMessageContentDataWithImageURL.m?80.88%?
    FIRIAMMessageDefinition.m?100.00%?
    FIRIAMModalViewController.m?0.00%?
    FIRIAMMsgFetcherUsingRestful.m?71.01%?
    FIRIAMRenderingEffectSetting.m?100.00%?
    FIRIAMRenderingWindowHelper.m?0.00%?
    FIRIAMRuntimeManager.m?0.00%?
    FIRIAMSDKModeManager.m?93.22%?
    FIRIAMSDKSettings.m?0.00%?
    FIRIAMServerMsgFetchStorage.m?0.00%?
    FIRIAMTimeFetcher.m?0.00%?
    FIRInAppMessaging+Bootstrap.m?0.00%?
    FIRInAppMessaging.m?3.37%?
    FIRInAppMessagingRenderingDataClasses.m?89.29%?
    NSString+FIRInterlaceStrings.m?100.00%?
    SwiftUIPreviewHelpers.swift?0.00%?
    UIApplication+FIRForegroundWindowScene.m?0.00%?
    UIColor+FIRIAMHexString.m?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fydRjYwYDA.html

@ncooke3 ncooke3 requested a review from paulb777 October 20, 2023 13:39
@google-oss-bot
Copy link

Size Report 1

Affected Products

  • FirebaseAppCheck

    TypeBase (3e4b721)Merge (96b97a7)Diff
    CocoaPods?-51.5 kB? (?)

  • FirebaseDatabase

    TypeBase (3e4b721)Merge (96b97a7)Diff
    CocoaPods?-51.5 kB? (?)

  • FirebaseFirestore

    TypeBase (3e4b721)Merge (96b97a7)Diff
    CocoaPods?-51.5 kB? (?)

  • FirebaseInAppMessaging

    TypeBase (3e4b721)Merge (96b97a7)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZrdslnQchu.html

@ncooke3 ncooke3 merged commit 4b26b31 into master Oct 20, 2023
77 checks passed
@ncooke3 ncooke3 deleted the nc/firestore-follow-up branch October 20, 2023 18:54
@firebase firebase locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: database api: firestore api: inappmessaging Firebase In App Messaging release-tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @google-oss-bot @paulb777