Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App Check] Add failure reasons for App Attest error cases #11956

Merged
merged 3 commits into from
Oct 19, 2023
Merged

[App Check] Add failure reasons for App Attest error cases #11956

merged 3 commits into from
Oct 19, 2023

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Oct 17, 2023 •
edited
Loading

This will allow developers to more granularly determine when errors occur in FIRAppAttestProvider (when performing generateKeyWithCompletionHandler:, attestKey:clientDataHash:completionHandler: or generateAssertion:clientDataHash:completionHandler:), along with additional debugging information (keyId and clientDataHash lengths).

#no-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023 •
edited
Loading

✅  No API diff detected

Commit: 3483fbe
Last updated: Thu Oct 19 08:40 PDT 2023
View workflow logs & download artifacts

@andrewheard andrewheard changed the title [App Check] Add error codes for App Attest failure cases [App Check] Add failure reasons for App Attest error cases Oct 17, 2023
@andrewheard andrewheard marked this pull request as ready for review October 17, 2023 22:24
@andrewheard andrewheard requested a review from paulb777 October 19, 2023 21:27
@andrewheard andrewheard merged commit f73ca95 into master Oct 19, 2023
52 checks passed
@andrewheard andrewheard deleted the ah/appattest-errors branch October 19, 2023 21:28
@paulb777 paulb777 mentioned this pull request Oct 20, 2023
Closed
This was referenced Oct 20, 2023
Merged
Merged
@andrewheard andrewheard mentioned this pull request Nov 1, 2023
Closed
This was referenced Nov 14, 2023
Closed
Closed
@firebase firebase locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ncooke3 ncooke3 Awaiting requested review from ncooke3

Assignees
No one assigned
Labels
api: appcheck
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewheard @paulb777 @google-oss-bot