[Passkey #5] Auth startPasskeySignInWithCompletion: and finalizePasskeySignInWithPlatformCredential:completion #11952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eySignInWithPlatformCredential:completion APIs
Generated by 🚫 Danger |
Apple API Diff ReportCommit: b03c13f FirebaseAuthClassesFIRAuth[ADDED] -startPasskeySignInWithCompletion:Swift:
+ func startPasskeySignIn () async throws -> ASAuthorizationPlatformPublicKeyCredentialAssertionRequest
Objective-C:
+ - ( void ) startPasskeySignInWithCompletion : ( nullable void ( ^ )( ASAuthorizationPlatformPublicKeyCredentialAssertionRequest * _Nullable , NSError * _Nullable )) completion ;[ADDED] -finalizePasskeySignInWithPlatformCredential:completion:Swift:
+ func finalizePasskeySignIn ( with platformCredential : ASAuthorizationPlatformPublicKeyCredentialAssertion ) async throws -> FIRAuthDataResult
Objective-C:
+ - ( void ) finalizePasskeySignInWithPlatformCredential : ( nonnull ASAuthorizationPlatformPublicKeyCredentialAssertion * ) platformCredential completion : ( nullable void ( ^ )( FIRAuthDataResult * _Nullable , NSError * _Nullable )) completion ; |
remove pbxproj file
renkelvin
reviewed
Oct 23, 2023
| @brief start sign in with passkey retrieving challenge from GCIP and create an assertion request. | ||
| @param completion Optionally; a block which creates a assertation request. | ||
|
|
||
| @remarks //TODO add possible error codes |
There was a problem hiding this comment.
What does this mean? Also add your ldap after TODO.
There was a problem hiding this comment.
Added ldap.
The reason for this is to follow the current public API reference format which includes a list of possible error codes. Please see an example here. I will fill this after error code bug (b/302700496) for backend is fixed.
| } | ||
| } | ||
|
|
||
| // TODO @liubin uncomment this after expires_in changes |
There was a problem hiding this comment.
We can include this in a future pr
There was a problem hiding this comment.
Got it, removed for now. Will add it back with the "expires_in" fix PR.
renkelvin
approved these changes
Oct 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added public APIs on FIRAuth level
TODO occurrences