Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[visionOS] Fix FirebaseInAppMessaging build on Xcode 15.1 beta 1 #11935

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

andrewheard
Copy link
Contributor

In Xcode 15.1 TARGET_OS_IOS is now 0 instead of 1 on visionOS. This PR fixes the build of Firebase In-App Messaging on Xcode 15.1 beta 1 for visionOS.

Note: google/GoogleUtilities#132 is also needed to fix the build (not yet tagged / released).

#no-changelog

@google-oss-bot google-oss-bot added the api: inappmessaging Firebase In App Messaging label Oct 13, 2023
@andrewheard andrewheard marked this pull request as ready for review October 13, 2023 19:18
@andrewheard andrewheard merged commit 9425f60 into master Oct 13, 2023
43 checks passed
@andrewheard andrewheard deleted the ah/visionos-fiam branch October 13, 2023 19:18
@firebase firebase locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: inappmessaging Firebase In App Messaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants