-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[auth-swift] merge master #11907
[auth-swift] merge master #11907
Conversation
* Require Xcode 14.1 * [Release Tooling] Make 'zip-builder' compatible with Xcode 14 * Cleanup approach and restore disabled code * Remove unneeded comment and whitespace * Delete empty symbol link on all platforms * Fix build issue left over from previous commit * [skip ci] Remove irrelevant comment * [skip ci] Remove irrelevant newline --------- Co-authored-by: Paul Beusterien <[email protected]>
* shared application fix * lint fix
This was missed in Firebase 10.3.0 because the search for Unreleased was case sensitive.
Added a changelog entry for Firebase Auth 10.13.0.
In Xcode 15 beta 5, TARGET_OS_XR was replaced with TARGET_OS_VISION in ObjC and os(xrOS) was replaced with os(visionOS) in Swift.
Co-authored-by: runner <[email protected]>
#11231 introduces some renamed methods, which broke the Combine build, see this workflow run: firebase/firebase-ios-sdk/actions/runs/5665691823 This PR should fix this.
* Make tests work against named db * setup jobs
Increase test timeout to de-flake testes in Google3
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Generated by 🚫 Danger |
Apple API Diff ReportCommit: 6e55f7e FirebaseFirestoreClassesFIRFirestore[ADDED] persistentCacheIndexManagerSwift:
+ var persistentCacheIndexManager : FIRPersistentCacheIndexManager ? { get }
Objective-C:
+ @property ( nonatomic , readonly , nullable ) FIRPersistentCacheIndexManager * persistentCacheIndexManager ; FirebaseAppCheckClassesFIRAppCheck[REMOVED] -tokenForcingRefresh:completion:Swift:
- func token ( forcingRefresh : Bool ) async throws -> FIRAppCheckToken
Objective-C:
- - ( void ) tokenForcingRefresh :( BOOL ) forcingRefresh completion :( nonnull void ( ^ )( FIRAppCheckToken * _Nullable , NSError * _Nullable )) handler ; [REMOVED] -limitedUseTokenWithCompletion:Swift:
- func limitedUseToken () async throws -> FIRAppCheckToken
Objective-C:
- - ( void ) limitedUseTokenWithCompletion : ( nonnull void ( ^ )( FIRAppCheckToken * _Nullable , NSError * _Nullable )) handler ; |
Merging here. Auth tests are passing. Other products will update to iOS 13 minimum later to address other failing tests. |
After rebasing auth-swift with master to this point, this PR switches to a merge strategy.
Now that the ObjC files are gone, everything needs to be reimplemented anyway and merging is faster. It will also enable past versions to remain functional.
Auth PRs will need to continue to be reimplemented in the
auth-swift
branch. As of this merge, everything that is in the base + #11532 is reimplemented and the Auth PRs merged here starting with #11554 will still need to be implemented in Swift.