Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[passkey #3] startPasskeySignIn RPC call #11889

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

Xiaoshouzi-gh
Copy link
Contributor

  1. Implemented start passkey sign in rpc call
  2. Defined startPasskeySignInRequest & Response
  3. Added Unit tests
    This flow has been tested against backend.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@Xiaoshouzi-gh Xiaoshouzi-gh marked this pull request as ready for review October 3, 2023 21:15
@@ -471,6 +484,15 @@ typedef void (^FIRStartPasskeyEnrollmentResponseCallback)(
*/
+ (void)startPasskeyEnrollment:(FIRStartPasskeyEnrollmentRequest *)request
callback:(FIRStartPasskeyEnrollmentResponseCallback)callback;

/** @fn startPasskeySignInt:callback:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "In"

@Xiaoshouzi-gh Xiaoshouzi-gh merged commit dfa40c0 into passkey-main Oct 4, 2023
@Xiaoshouzi-gh Xiaoshouzi-gh deleted the passkey-start-signin branch October 4, 2023 14:48
@firebase firebase locked and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants