Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Passkey #2] finalize passkey enrollment rpc #11885

Merged
merged 5 commits into from
Oct 4, 2023
Merged

[Passkey #2] finalize passkey enrollment rpc #11885

merged 5 commits into from
Oct 4, 2023

Conversation

Xiaoshouzi-gh
Copy link
Contributor

  1. Implemented finalizePasskeyEnrollment rpc call
  2. Defined finalizePasskeyEnrollment Request and Response object
  3. Added unit tests

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@Xiaoshouzi-gh
1. Implemented finalizePasskeyEnrollment rpc call
5bf50ce 
2. Defined finalizePasskeyEnrollment Request and Response object
3. Added unit tests
@Xiaoshouzi-gh
ran check.sh
127a6e9
@Xiaoshouzi-gh
exclude import from watchOS
b78ce9e
@Xiaoshouzi-gh Xiaoshouzi-gh marked this pull request as ready for review October 3, 2023 20:57
@Xiaoshouzi-gh Xiaoshouzi-gh merged commit 33f3636 into passkey-main Oct 4, 2023
18 of 20 checks passed
@Xiaoshouzi-gh Xiaoshouzi-gh deleted the passkey-fenroll branch October 4, 2023 17:47
@firebase firebase locked and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@renkelvin renkelvin renkelvin approved these changes

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xiaoshouzi-gh @google-oss-bot @renkelvin