Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Speed up xcodebuilds by only testing #11742

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Aug 29, 2023

See description in #11708. xcodebuild test will do a build so running xcodebuild build test is doing an extra build.

Outstanding follow-up work

  • Some of the xcodebuild invocations don't look to ever be called on CI
  • The script should trigger all CI workflows that depend on it

#no-changelog

@ncooke3 ncooke3 marked this pull request as draft August 29, 2023 16:59
@ncooke3 ncooke3 marked this pull request as ready for review September 7, 2023 16:28
@paulb777
Copy link
Member

@ncooke3 Any reason not to merge as is?

@ncooke3
Copy link
Member Author

ncooke3 commented Oct 26, 2023

@ncooke3 Any reason not to merge as is?

No, I was keeping it open until I addressed the follow-up work, but I have not had the time to dig deeper. I'll merge and open an issue to track the remaining work.

@ncooke3 ncooke3 merged commit 571bdc8 into master Oct 26, 2023
@ncooke3 ncooke3 deleted the nc/speed-up-xcodebuild branch October 26, 2023 14:19
@ncooke3
Copy link
Member Author

ncooke3 commented Oct 26, 2023

Tracking next steps in #12007

@firebase firebase locked and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants