Skip to content

Commit

Permalink
[Core] Add FIRGetLoggerLevel function (#12065)
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewheard authored Nov 7, 2023
1 parent 8c04b87 commit afca289
Show file tree
Hide file tree
Showing 4 changed files with 36 additions and 1 deletion.
5 changes: 5 additions & 0 deletions FirebaseCore/Extension/FIRLogger.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@ extern "C" {
*/
void FIRSetAnalyticsDebugMode(BOOL analyticsDebugMode);

/**
* Gets the current FIRLoggerLevel.
*/
FIRLoggerLevel FIRGetLoggerLevel(void);

/**
* Changes the default logging level of FirebaseLoggerLevelNotice to a user-specified level.
* The default level cannot be set above FirebaseLoggerLevelNotice if the app is running from App
Expand Down
4 changes: 4 additions & 0 deletions FirebaseCore/Sources/FIRLogger.m
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ void FIRLoggerInitializeASL(void) {
sFIRAnalyticsDebugMode = analyticsDebugMode;
}

FIRLoggerLevel FIRGetLoggerLevel(void) {
return (FIRLoggerLevel)GULGetLoggerLevel();
}

void FIRSetLoggerLevel(FIRLoggerLevel loggerLevel) {
FIRLoggerInitializeASL();
GULSetLoggerLevel((GULLoggerLevel)loggerLevel);
Expand Down
26 changes: 26 additions & 0 deletions FirebaseCore/Tests/Unit/FIRLoggerTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -185,5 +185,31 @@ - (void)testFIRLoggerLevelValues {
XCTAssertEqual(FIRLoggerLevelDebug, ASL_LEVEL_DEBUG);
}

- (void)testFIRGetLoggerLevel {
FIRLoggerLevel loggerLevel = FIRGetLoggerLevel();

// The default logger level is FIRLoggerLevelNotice.
XCTAssertEqual(loggerLevel, FIRLoggerLevelNotice);
}

- (void)testFIRSetLoggerLevel {
FIRSetLoggerLevel(FIRLoggerLevelDebug);

FIRLoggerLevel loggerLevel = FIRGetLoggerLevel();

// The default logger level is FIRLoggerLevelNotice.
XCTAssertEqual(loggerLevel, FIRLoggerLevelDebug);
}

- (void)testFIRResetLogger_ResetsLoggerLevel {
FIRSetLoggerLevel(FIRLoggerLevelDebug);

FIRResetLogger();
FIRLoggerLevel loggerLevel = FIRGetLoggerLevel();

// The default logger level is FIRLoggerLevelNotice.
XCTAssertEqual(loggerLevel, FIRLoggerLevelNotice);
}

@end
#endif
2 changes: 1 addition & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ let package = Package(
),
.package(
url: "https://github.com/google/GoogleUtilities.git",
"7.11.0" ..< "8.0.0"
"7.12.0" ..< "8.0.0"
),
.package(
url: "https://github.com/google/gtm-session-fetcher.git",
Expand Down

0 comments on commit afca289

Please sign in to comment.