Skip to content

Commit

Permalink
Updating changelog and formating
Browse files Browse the repository at this point in the history
  • Loading branch information
eldhosembabu committed Sep 29, 2023
1 parent 78cf8cf commit 9f050b5
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
3 changes: 3 additions & 0 deletions FirebaseABTesting/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Unreleased
- [fixed] Fix crash caused by empty experiment payload.

# 10.14.0
- [fixed] Fix crash caused by mutating array during iteration. (#11669)

Expand Down
14 changes: 7 additions & 7 deletions FirebaseABTesting/Sources/ABTConditionalUserPropertyController.m
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,13 @@ - (void)setExperimentWithOrigin:(NSString *)origin
@"Failed to get conditional user properties from Firebase Analytics.");
return;
}
if(payload.experimentId==nil){
// When doing experiment test on devices, the payload could be empty. Returning here to prevent app crash.
FIRLogInfo(kFIRLoggerABTesting, @"I-ABT000020",
@"Experiment Id in payload is empty.");
return;
}

if (payload.experimentId == nil) {
// When doing experiment test on devices, the payload could be empty. Returning here to prevent
// app crash.
FIRLogInfo(kFIRLoggerABTesting, @"I-ABT000020", @"Experiment Id in payload is empty.");
return;
}

if (maxNumOfExperiments <= experiments.count) {
ABTExperimentPayloadExperimentOverflowPolicy overflowPolicy =
Expand Down

0 comments on commit 9f050b5

Please sign in to comment.