[Infra] Remove CoreDiagnostics library and references (#10259)

* [Infra] Remove CoreDiagnostics library and references * Style localize_podfile.swift * Add GDT to SharedTestUtils * Update GoogleUtilities.cmake config * Run all CI * Update GoogleUtilities.cmake config (2) * Resolve FIRApp.m TODO * [skip ci] Revert Gemfile
firebase · Sep 26, 2022 · 43c62f0 · 43c62f0
1 parent af1201c
commit 43c62f0
Show file tree

Hide file tree

Showing 58 changed files with 18 additions and 2,610 deletions.
diff --git a/.github/workflows/core-diagnostics.yml b/.github/workflows/core-diagnostics.yml
diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml
@@ -4,7 +4,6 @@ on:
   pull_request:
     paths:
     - 'FirebaseCore**'
-    - 'Interop/CoreDiagnostics/Public/*.h'
     - '.github/workflows/core.yml'
     - 'Gemfile*'
   schedule:

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -293,4 +293,3 @@ add_subdirectory(FirebaseAppCheck/Interop)
 add_subdirectory(FirebaseCore)
 add_subdirectory(Firestore)
 add_subdirectory(FirebaseAuth/Interop)
-add_subdirectory(Interop/CoreDiagnostics)
diff --git a/CocoapodsIntegrationTest/TestEnvironments/Cocoapods_multiprojects_frameworks/Podfile b/CocoapodsIntegrationTest/TestEnvironments/Cocoapods_multiprojects_frameworks/Podfile
@@ -12,7 +12,6 @@ target 'CocoapodsIntegrationTest' do
   pod 'FirebaseAppDistribution', :path => '../'
   pod 'FirebaseAppCheckInterop', :path => '../'
   pod 'FirebaseCore', :path => '../'
-  pod 'FirebaseCoreDiagnostics', :path => '../'
   pod 'FirebaseCoreExtension', :path => '../'
   pod 'FirebaseCoreInternal', :path => '../'
   pod 'FirebaseCrashlytics', :path => '../'

diff --git a/CoreOnly/NOTICES b/CoreOnly/NOTICES
@@ -261,7 +261,6 @@ FirebaseAppDistribution
 FirebaseAuth
 FirebaseAuthInterop
 FirebaseCore
-FirebaseCoreDiagnostics
 FirebaseCoreExtension
 FirebaseCoreInternal
 FirebaseDatabaseSwift

diff --git a/CoreOnly/Tests/FirebasePodTest/FirebasePodTest.xcodeproj/project.pbxproj b/CoreOnly/Tests/FirebasePodTest/FirebasePodTest.xcodeproj/project.pbxproj
@@ -297,14 +297,12 @@
 					"$(inherited)",
 					../../../CoreOnly/Sources,
 					"\"${PODS_CONFIGURATION_BUILD_DIR}/FirebaseCore/FirebaseCore.framework/Headers\"",
-					"\"${PODS_CONFIGURATION_BUILD_DIR}/FirebaseCoreDiagnostics/FirebaseCoreDiagnostics.framework/Headers\"",
 					"\"${PODS_CONFIGURATION_BUILD_DIR}/FirebaseInstanceID/FirebaseInstanceID.framework/Headers\"",
 					"\"${PODS_CONFIGURATION_BUILD_DIR}/GoogleDataTransport/GoogleDataTransport.framework/Headers\"",
 					"\"${PODS_CONFIGURATION_BUILD_DIR}/GoogleUtilities/GoogleUtilities.framework/Headers\"",
 					"\"${PODS_CONFIGURATION_BUILD_DIR}/nanopb/nanopb.framework/Headers\"",
 					"\"${PODS_ROOT}/Headers/Public\"",
 					"\"${PODS_ROOT}/Headers/Public/Firebase\"",
-					"\"${PODS_ROOT}/Headers/Public/FirebaseCoreDiagnosticsInterop\"",
 				);
 				INFOPLIST_FILE = FirebasePodTest/Info.plist;
 				LD_RUNPATH_SEARCH_PATHS = (
@@ -327,14 +325,12 @@
 					"$(inherited)",
 					../../../CoreOnly/Sources,
 					"\"${PODS_CONFIGURATION_BUILD_DIR}/FirebaseCore/FirebaseCore.framework/Headers\"",
-					"\"${PODS_CONFIGURATION_BUILD_DIR}/FirebaseCoreDiagnostics/FirebaseCoreDiagnostics.framework/Headers\"",
 					"\"${PODS_CONFIGURATION_BUILD_DIR}/FirebaseInstanceID/FirebaseInstanceID.framework/Headers\"",
 					"\"${PODS_CONFIGURATION_BUILD_DIR}/GoogleDataTransport/GoogleDataTransport.framework/Headers\"",
 					"\"${PODS_CONFIGURATION_BUILD_DIR}/GoogleUtilities/GoogleUtilities.framework/Headers\"",
 					"\"${PODS_CONFIGURATION_BUILD_DIR}/nanopb/nanopb.framework/Headers\"",
 					"\"${PODS_ROOT}/Headers/Public\"",
 					"\"${PODS_ROOT}/Headers/Public/Firebase\"",
-					"\"${PODS_ROOT}/Headers/Public/FirebaseCoreDiagnosticsInterop\"",
 				);
 				INFOPLIST_FILE = FirebasePodTest/Info.plist;
 				LD_RUNPATH_SEARCH_PATHS = (

diff --git a/CoreOnly/Tests/FirebasePodTest/Podfile b/CoreOnly/Tests/FirebasePodTest/Podfile
@@ -15,7 +15,6 @@ target 'FirebasePodTest' do
   pod 'FirebaseAppDistribution', :path => '../../../'
   pod 'FirebaseAuth', :path => '../../../'
   pod 'FirebaseCore', :path => '../../../'
-  pod 'FirebaseCoreDiagnostics', :path => '../../../'
   pod 'FirebaseCrashlytics', :path => '../../../'
   pod 'FirebaseDatabase', :path => '../../../'
   pod 'FirebaseDynamicLinks', :path => '../../../'
@@ -34,7 +33,6 @@ target 'FirebasePodTest' do
   pod 'FirebaseAppCheckInterop', :path => '../../../'
   pod 'FirebaseAuthInterop', :path => '../../../'
   pod 'FirebaseMessagingInterop', :path => '../../../'
-  pod 'FirebaseCoreDiagnostics', :path => '../../../'
   pod 'FirebaseCoreInternal', :path => '../../../'
   pod 'FirebaseCoreExtension', :path => '../../../'
   pod 'FirebaseSharedSwift', :path => '../../../'

diff --git a/Dangerfile b/Dangerfile
@@ -93,7 +93,6 @@ has_license_changes = didModify(["LICENSE"])
 @has_auth_api_changes = hasChangesIn("FirebaseAuth/Sources/Public/")
 @has_core_changes = hasChangesIn([
   "FirebaseCore",
-  "Firebase/CoreDiagnostics/",
   "CoreOnly/"])
 @has_core_api_changes = hasChangesIn("FirebaseCore/Sources/Public/")
 @has_crashlytics_changes = hasChangesIn("Crashlytics")