Skip to content

[Messaging] Fix subscription not completing sometimes #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

If the messaging token is received via Installations, which can happen if it is cached, it wasn't setting the flags to allow subscriptions to work correctly, causing them to hang. Set the flags, and resolve any pending subscriptions when the token is received via that mechanic.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Running locally.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice merged commit a06d206 into main May 29, 2025
28 checks passed
@a-maurice a-maurice deleted the am-messaging_subscriptions branch May 29, 2025 18:09
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label May 29, 2025
Copy link

github-actions bot commented May 29, 2025

✅  Integration test succeeded!

Requested by @a-maurice on commit a06d206
Last updated: Thu May 29 12:57 PDT 2025
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 29, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants