Update GaugeManager to better support AQS #6693
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the behaviour of AQS w/ Fireperf, an AQS session isn't available when (currently) logging gauge metadata. Changes: - Remove the current logging of gauge metadata - will be re-introduced in a future PR. - Switch Gauge collection from `scheduleAtFixedRate` to `scheduleWithFixedDelay`. As [documented](https://stackoverflow.com/a/78405653), this *should* prevent a potentially large amounts of gauge collection if a process is cached, and then restored during a verbose session - which *should* make it work better w/ AQS. - Remove API restricted behaviour which is no longer relevant.
Vertex AI Mock Responses Check
|
Coverage Report 1Affected Products
Test Logs |
Test Results 110 files 110 suites 2m 30s ⏱️ Results for commit c9c0441. ♻️ This comment has been updated with latest results. |
Size Report 1Affected Products
Test Logs |
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/perf/FirebasePerformance.html 2025-04-04 17:45:39.838634078 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/perf/FirebasePerformance.html 2025-04-04 17:43:11.784617789 +0000
@@ -94,6 +94,27 @@
</colgroup>
<thead>
<tr>
+ <th colspan="100%"><h3>Protected fields</h3></th>
+ </tr>
+ </thead>
+ <tbody class="list">
+ <tr>
+ <td><code>final <a href="/docs/reference/android/com/google/firebase/sessions/api/SessionSubscriber.html">SessionSubscriber</a></code></td>
+ <td>
+ <div><code><a href="/docs/reference/android/com/google/firebase/perf/FirebasePerformance.html#sessionSubscriber()">sessionSubscriber</a></code></div>
+ </td>
+ </tr>
+ </tbody>
+ </table>
+ </div>
+ <div class="devsite-table-wrapper">
+ <table class="responsive">
+ <colgroup>
+ <col width="40%">
+ <col>
+ </colgroup>
+ <thead>
+ <tr>
<th colspan="100%"><h3>Public methods</h3></th>
</tr>
</thead>
@@ -179,6 +200,13 @@
</div>
</div>
<div class="list">
+ <h2>Protected fields</h2>
+ <div class="api-item"><a name="getSessionSubscriber()"></a><a name="setSessionSubscriber()"></a><a name="getSessionSubscriber--"></a><a name="setSessionSubscriber--"></a>
+ <h3 class="api-name" id="sessionSubscriber()">sessionSubscriber</h3>
+ <pre class="api-signature no-pretty-print">protected final <a href="/docs/reference/android/com/google/firebase/sessions/api/SessionSubscriber.html">SessionSubscriber</a> <a href="/docs/reference/android/com/google/firebase/perf/FirebasePerformance.html#sessionSubscriber()">sessionSubscriber</a></pre>
+ </div>
+ </div>
+ <div class="list">
<h2>Public methods</h2>
<div class="api-item"><a name="getInstance--"></a><a name="getinstance"></a>
<h3 class="api-name" id="getInstance()">getInstance</h3>--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/perf/FirebasePerformance.html 2025-04-04 17:45:39.825633989 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/perf/FirebasePerformance.html 2025-04-04 17:43:11.778617730 +0000
@@ -150,6 +150,27 @@
</tbody>
</table>
</div>
+ <div class="devsite-table-wrapper">
+ <table class="responsive">
+ <colgroup>
+ <col width="40%">
+ <col>
+ </colgroup>
+ <thead>
+ <tr>
+ <th colspan="100%"><h3>Protected properties</h3></th>
+ </tr>
+ </thead>
+ <tbody class="list">
+ <tr>
+ <td><code><a href="/docs/reference/kotlin/com/google/firebase/sessions/api/SessionSubscriber.html">SessionSubscriber</a>!</code></td>
+ <td>
+ <div><code><a href="/docs/reference/kotlin/com/google/firebase/perf/FirebasePerformance.html#sessionSubscriber()">sessionSubscriber</a></code></div>
+ </td>
+ </tr>
+ </tbody>
+ </table>
+ </div>
<div class="list">
<h2>Constants</h2>
<div class="api-item"><a name="getMAX_ATTRIBUTE_KEY_LENGTH()"></a><a name="setMAX_ATTRIBUTE_KEY_LENGTH()"></a><a name="getMAX_ATTRIBUTE_KEY_LENGTH--"></a><a name="setMAX_ATTRIBUTE_KEY_LENGTH--"></a>
@@ -469,6 +490,13 @@
</div>
</div>
</div>
+ <div class="list">
+ <h2>Protected properties</h2>
+ <div class="api-item"><a name="getSessionSubscriber()"></a><a name="setSessionSubscriber()"></a><a name="getSessionSubscriber--"></a><a name="setSessionSubscriber--"></a>
+ <h3 class="api-name" id="sessionSubscriber()">sessionSubscriber</h3>
+ <pre class="api-signature no-pretty-print">protected val <a href="/docs/reference/kotlin/com/google/firebase/perf/FirebasePerformance.html#sessionSubscriber()">sessionSubscriber</a>: <a href="/docs/reference/kotlin/com/google/firebase/sessions/api/SessionSubscriber.html">SessionSubscriber</a>!</pre>
+ </div>
+ </div>
</body>
</html>
|
|
The public api surface has changed for the subproject firebase-perf: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
mrober
force-pushed
the
fireperf-aqs
branch
2 times, most recently
from
60f2e77 to
7d9c0bf
Compare
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial attempt at changing gauge collection to use AQS.
PerfSessionFirebasePerfEarlybut only logs them once AQS sends a session,DebugEnforcementCheckin additional locations.