Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Rename pytest teardown methods from deprecated teardown to teardown_method #768

Merged
merged 1 commit into from
Feb 13, 2024
Merged

[chore] Rename pytest teardown methods from deprecated teardown to teardown_method #768

merged 1 commit into from
Feb 13, 2024

Conversation

jonathanedey
Copy link
Contributor

@jonathanedey jonathanedey marked this pull request as ready for review February 13, 2024 19:13
lahirumaramba
lahirumaramba approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@jonathanedey jonathanedey merged commit 0752992 into master Feb 13, 2024
13 checks passed
@jonathanedey jonathanedey deleted the je-teardown branch February 13, 2024 20:53
jonathanedey added a commit that referenced this pull request Feb 13, 2024
@jonathanedey
[chore] Rename pytest teardown methods from deprecated teardown to …
c165f36 
…`teardown_method` (#768)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

@jonathanedey jonathanedey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanedey @lahirumaramba