Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release and ci workflows to use GITHUB_OUTPUT and bump actions/checkout to v4. #752

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Update release and ci workflows to use GITHUB_OUTPUT and bump actions/checkout to v4. #752

merged 2 commits into from
Jan 3, 2024

Conversation

jonathanedey
Copy link
Contributor

No description provided.

@jonathanedey jonathanedey added the release:stage Stage a release candidate label Jan 2, 2024
@jonathanedey jonathanedey changed the title Update release workflow to use GITHUB_OUTPUT and bump actions/checkout to v4. Update release and ci workflows to use GITHUB_OUTPUT and bump actions/checkout to v4. Jan 2, 2024
@jonathanedey
Copy link
Contributor Author

Currently we use a forked version of a (no longer maintained) release github action which still uses set-output:
https://github.com/firebase/firebase-admin-python/blob/master/.github/workflows/release.yml#L110

Would we want to consider moving this to a new maintained source like https://github.com/ncipollo/release-action?

@jonathanedey jonathanedey marked this pull request as ready for review January 3, 2024 14:29
lahirumaramba
lahirumaramba approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@lahirumaramba
Copy link
Member

Currently we use a forked version of a (no longer maintained) release github action which still uses set-output: https://github.com/firebase/firebase-admin-python/blob/master/.github/workflows/release.yml#L110

Would we want to consider moving this to a new maintained source like https://github.com/ncipollo/release-action?

good call! I think we should. Let's do it in a separate PR though. Is there an official github action for this now?

@jonathanedey
Copy link
Contributor Author

good call! I think we should. Let's do it in a separate PR though. Is there an official github action for this now?

The original repo the fork was based on was the official one until they stopped maintaining it in 2021.

They left suggested alternatives with the one i linked being the most active but the thread of mentions shows a few repos who decided to use https://github.com/softprops/action-gh-release instead.

@jonathanedey jonathanedey merged commit df94f8b into master Jan 3, 2024
11 checks passed
@jonathanedey jonathanedey deleted the je-github-actions branch January 3, 2024 19:41
jonathanedey added a commit that referenced this pull request Feb 13, 2024
@jonathanedey
Update release and ci workflows to use GITHUB_OUTPUT and bump `acti…
9182b83 
…ons/checkout` to v4. (#752)

* Update release workflow to use GITHUB_OUTPUT.

* Use actions/checkout@v4 for nightly builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

@lahirumaramba lahirumaramba

Labels
release:stage Stage a release candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanedey @lahirumaramba