Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): Fix iOSBundleId parameter name #727

Merged
merged 2 commits into from
Dec 19, 2023
Merged

fix(auth): Fix iOSBundleId parameter name #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c186626
Fix iOSBundleId parameter name
jesuslosada Oct 3, 2023
9c331a1
Merge branch 'master' into fix-ios-bundle-id-parameter
lahirumaramba Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion firebase_admin/_user_mgt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ def encode_action_code_settings(settings):
if not isinstance(settings.ios_bundle_id, str):
raise ValueError('Invalid value provided for ios_bundle_id: {0}'
.format(settings.ios_bundle_id))
parameters['iosBundleId'] = settings.ios_bundle_id
parameters['iOSBundleId'] = settings.ios_bundle_id

# android_* attributes
if (settings.android_minimum_version or settings.android_install_app) \
Expand Down
4 changes: 2 additions & 2 deletions tests/test_user_mgt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1369,7 +1369,7 @@ def test_valid_data(self):
assert parameters['continueUrl'] == data['url']
assert parameters['canHandleCodeInApp'] == data['handle_code_in_app']
assert parameters['dynamicLinkDomain'] == data['dynamic_link_domain']
assert parameters['iosBundleId'] == data['ios_bundle_id']
assert parameters['iOSBundleId'] == data['ios_bundle_id']
assert parameters['androidPackageName'] == data['android_package_name']
assert parameters['androidMinimumVersion'] == data['android_minimum_version']
assert parameters['androidInstallApp'] == data['android_install_app']
Expand Down Expand Up @@ -1529,7 +1529,7 @@ def _validate_request(self, request, settings=None):
assert request['continueUrl'] == settings.url
assert request['canHandleCodeInApp'] == settings.handle_code_in_app
assert request['dynamicLinkDomain'] == settings.dynamic_link_domain
assert request['iosBundleId'] == settings.ios_bundle_id
assert request['iOSBundleId'] == settings.ios_bundle_id
assert request['androidPackageName'] == settings.android_package_name
assert request['androidMinimumVersion'] == settings.android_minimum_version
assert request['androidInstallApp'] == settings.android_install_app