Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): Add TOTP support in Project and Tenant config #682

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

feat(auth): Add TOTP support in Project and Tenant config #682

wants to merge 28 commits into from

Conversation

pragatimodi
Copy link
Contributor

@pragatimodi pragatimodi commented Mar 15, 2023 •
edited by lahirumaramba
Loading

TOTP Support for Project and Tenant

RELEASE NOTES: Added TOTP as a multi-factor option in project and tenant configuration.

@pragatimodi
1. Adding Multi Factor Auth Configuration
44586d7 
2. Added TOTP Support for Tenant
3. Added Unit Tests for MFA Config
4. Added Unit Tests for Tenant Config with respect to MFA
@pragatimodi
Updating list[ProviderConfig] to List[ProviderConfig]
b625e13
@pragatimodi
1. Added a project_config_mgt file
c002232 
2. Unit tests for project_config_mgt
3. Formatting changes
@pragatimodi pragatimodi marked this pull request as draft March 15, 2023 20:32
@pragatimodi pragatimodi requested a review from renkelvin March 15, 2023 20:33
@pragatimodi pragatimodi marked this pull request as ready for review March 21, 2023 18:35
@lahirumaramba lahirumaramba added release-note release:stage Stage a release candidate labels Mar 29, 2023
lahirumaramba
lahirumaramba reviewed Mar 29, 2023
View reviewed changes
firebase_admin/_auth_client.py Outdated Show resolved Hide resolved
firebase_admin/_auth_providers.py Outdated Show resolved Hide resolved
lahirumaramba and others added 3 commits May 26, 2023 10:59
@lahirumaramba @pragatimodi
chore: Fix pypy tests (#694)
7e53e61
@pragatimodi
chore(auth): Update Auth API to v2 (#691)
6a4f451 
* `v2beta1` -> `v2`

* Reverting auto formatting changes

* undo auto formatting
@samueldg @lahirumaramba @pragatimodi
Add release notes to project URLs in PyPI (#679)
0684915 
It's useful to be able to navigate to the release notes easily
from the package index when upgrading.

"Release Notes" is a special keyword that will have the scroll icon
in the project page.

A random example:

* https://pypi.org/project/streamlit/
* https://github.com/streamlit/streamlit/blob/815a3ea6fa3e7f9099b479e8365bd3a5874ddc35/lib/setup.py#L111

Co-authored-by: Lahiru Maramba <[email protected]>
@pragatimodi pragatimodi force-pushed the mfa-totp branch 2 times, most recently from cd7aed2 to 0684915 Compare May 26, 2023 18:03
@pragatimodi pragatimodi requested a review from renkelvin June 2, 2023 15:43
Xiaoshouzi-gh
Xiaoshouzi-gh reviewed Jun 7, 2023
View reviewed changes
Copy link

@Xiaoshouzi-gh Xiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments.

firebase_admin/multi_factor_config_mgt.py Outdated Show resolved Hide resolved
firebase_admin/project_config_mgt.py Outdated Show resolved Hide resolved
integration/test_project_config_mgt.py Outdated Show resolved Hide resolved
@pragatimodi
Addressing feedback
8b87e10 
Importing configs directly

fix warnings

fix warnings

fix warnings
kevinthecheung
kevinthecheung requested changes Jun 14, 2023
View reviewed changes
firebase_admin/multi_factor_config_mgt.py Outdated Show resolved Hide resolved
firebase_admin/multi_factor_config_mgt.py Outdated Show resolved Hide resolved
firebase_admin/multi_factor_config_mgt.py Outdated Show resolved Hide resolved
firebase_admin/multi_factor_config_mgt.py Outdated Show resolved Hide resolved
firebase_admin/multi_factor_config_mgt.py Outdated Show resolved Hide resolved
firebase_admin/project_config_mgt.py Outdated Show resolved Hide resolved
firebase_admin/project_config_mgt.py Outdated Show resolved Hide resolved
firebase_admin/project_config_mgt.py Outdated Show resolved Hide resolved
firebase_admin/project_config_mgt.py Outdated Show resolved Hide resolved
firebase_admin/project_config_mgt.py Show resolved Hide resolved
kevinthecheung
kevinthecheung approved these changes Sep 8, 2023
View reviewed changes
firebase_admin/multi_factor_config_mgt.py Outdated Show resolved Hide resolved
firebase_admin/multi_factor_config_mgt.py Outdated Show resolved Hide resolved
firebase_admin/multi_factor_config_mgt.py Outdated Show resolved Hide resolved
firebase_admin/multi_factor_config_mgt.py Outdated Show resolved Hide resolved
@pstrav
Copy link

pstrav commented Apr 19, 2024

@kevinthecheung @Xiaoshouzi-gh do we have an ETA on this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiaoshouzi-gh Xiaoshouzi-gh Xiaoshouzi-gh approved these changes

@kevinthecheung kevinthecheung kevinthecheung approved these changes

@renkelvin renkelvin renkelvin approved these changes

@lahirumaramba lahirumaramba Awaiting requested review from lahirumaramba

Assignees
No one assigned
Labels
release:stage Stage a release candidate release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pragatimodi @pstrav @lahirumaramba @renkelvin @kevinthecheung @Xiaoshouzi-gh @samueldg