-
Notifications
You must be signed in to change notification settings - Fork 324
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Escape release tag body and change PyPi to use trusted publisher…
… for authentication.
- Loading branch information
1 parent
2376584
commit 0a37c87
Showing
2 changed files
with
7 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,6 +92,11 @@ jobs: | |
startsWith(github.event.pull_request.title, '[chore] Release ') | ||
|
||
runs-on: ubuntu-latest | ||
permissions: | ||
# Used to create a short-lived OICD token which is given to PyPi to identify this workflow job | ||
# See: https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect#adding-permissions-settings | ||
# and https://docs.pypi.org/trusted-publishers/using-a-publisher/ | ||
id-token: write | ||
|
||
steps: | ||
- name: Checkout source for publish | ||
|
@@ -116,10 +121,7 @@ jobs: | |
--notes "${{ steps.preflight.outputs.changelog }}" | ||
|
||
- name: Publish to Pypi | ||
uses: pypa/[email protected] | ||
with: | ||
user: firebase | ||
password: ${{ secrets.PYPI_PASSWORD }} | ||
uses: pypa/gh-action-pypi-publish@release/v1 | ||
|
||
# Post to Twitter if explicitly opted-in by adding the label 'release:tweet'. | ||
- name: Post to Twitter | ||
|