Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: error handling in firestore-internal for version extension #1843

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Seung-o
Copy link

@Seung-o Seung-o commented Aug 1, 2022

Discussion

  • Bug: Async Problem

I think firebase-internal.ts has async problem. It goes to if-else state before credential is created. So, in my case, I normally send credential in nestJS project with applicationDefault() method and credential was consoled out to be instance ServiceAccountCredential, but it gave error.

So, I suggest using try-catch statement in firestore-internal.ts and it would handle origin error. Also, in 'else' case It returns original credential.

Testing

  • I did all the test
  • Success percentage was 99.4 % ( 3 errors occurred )
  • 3 errors was engaged with FirestoreSerivce constructor, but i did not modify it.

API Changes

  • There is no API Changes.

@google-cla
Copy link

google-cla bot commented Aug 1, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant