add: error handling in firestore-internal for version extension #1843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
I think firebase-internal.ts has async problem. It goes to if-else state before credential is created. So, in my case, I normally send credential in nestJS project with
applicationDefault()
method and credential was consoled out to be instance ServiceAccountCredential, but it gave error.So, I suggest using try-catch statement in firestore-internal.ts and it would handle origin error. Also, in 'else' case It returns original credential.
Testing
API Changes