feat(firestore-bigquery-changetracker): support non-default db #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabljac
force-pushed
the
@invertase/changetracker-v2
branch
from
66b8ec8 to
c0cf2a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves to v2 on the change tracker package, so that the extension can also move to v2.
During this PR I had to add a bunch of jest.spyOn as the current tests are intractable when one fails.
I also had to regen package-locks etc as locally the change tracker had been
npm link'd to other packages and the extension.It seems Lerna doesn't respect package.json and tries to link the change tracker anyway.