feat(firestore-send-email): migrate to v2 cloud function #2359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the firestore-send-email extension to use the v2 Cloud Function trigger and supports non-default Firestore databases. The changes include updates to type definitions, modifications in index.ts to adopt Firestore v2 APIs, and corresponding updates in configuration, documentation, and changelog.
Reviewed Changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| functions/src/types.ts | Added new config fields for Firestore instance identification and region. |
| functions/src/index.ts | Modified Firestore API usages and trigger setup to support v2 functions and types. |
| functions/src/config.ts | Added new configuration properties for database and databaseRegion. |
| extension.yaml | Updated function type to firebaseextensions.v1beta.v2function, version bump, and config. |
| README.md | Updated documentation to reflect new Firestore instance configuration parameters. |
| POSTINSTALL.md | Updated instructions for accessing non-default Firestore databases post-installation. |
| CHANGELOG.md | Documented version bump and migration to v2 Firestore trigger. |
Files not reviewed (3)
- project/.firebaserc: Language not supported
- project/.gitignore: Language not supported
- project/firebase.json: Language not supported
CorieW
force-pushed
the
@invertase/firestore-send-email-v2
branch
from
2e69f51 to
ca73458
Compare
CorieW
force-pushed
the
@invertase/firestore-send-email-v2
branch
from
99bc96a to
a719342
Compare
CorieW
force-pushed
the
@invertase/firestore-send-email-v2
branch
from
a719342 to
b75d88a
Compare
cabljac
reviewed
Mar 31, 2025
cabljac
reviewed
Mar 31, 2025
fix: add defaults to config.ts to make tests run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2002
need to test