Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move duplicate element check to before first pass #968

Closed
wants to merge 1 commit into from

Conversation

MauricioUyaguari
Copy link
Member

@MauricioUyaguari MauricioUyaguari commented Mar 21, 2022

Summary

How did you test this change?

Helps with #927

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2022

⚠️ No Changeset found

Latest commit: 013aaa7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label Mar 21, 2022
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #968 (013aaa7) into master (6d8ee50) will decrease coverage by 0.00%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           master     #968      +/-   ##
==========================================
- Coverage   42.61%   42.60%   -0.01%     
==========================================
  Files         969      969              
  Lines       44561    44559       -2     
  Branches    10348    10349       +1     
==========================================
- Hits        18989    18986       -3     
- Misses      25498    25499       +1     
  Partials       74       74              
Impacted Files Coverage Δ
.../to/V1_ProtocolToMetaModelGraphFirstPassBuilder.ts 100.00% <ø> (ø)
packages/legend-graph/src/graph/PureModel.ts 78.80% <75.00%> (-0.08%) ⬇️
...rc/models/protocols/pure/v1/V1_PureGraphManager.ts 56.67% <100.00%> (+0.44%) ⬆️

@MauricioUyaguari MauricioUyaguari marked this pull request as ready for review March 22, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant