Integration with Redis for Legend Session Store #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes missing unit tests and workarounds that will be corrected once contribution is approved following a demo
…d fields - Created SessionStoreFactory - Created inner classes to represent MongoDB and Redis Configurations uniquely - Added new abstract method, getSessionAttribute, implemented by both MongoDB and Redis - Changed SessionStore from abstract class to interface - Added transactions within Redis create session so expire is set atomically with key creation
Includes missing unit tests and workarounds that will be corrected once contribution is approved following a demo
|
@pierredebelen bringing this back up for your attention. Please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @pierredebelen