minor updates to ArtifactGenerationExtension #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
MauricioUyaguari
requested review from
pierredebelen,
davidharte-gs,
aormerod-gs,
gs-ssh16,
epsstan,
kevin-m-knight-gs,
rafaelbey,
aziemchawdhary-gs and
elopezcastro
as code owners
MauricioUyaguari
force-pushed
the
updateExtension
branch
3 times, most recently
from
40296dc
to
eee8274
Compare
akphi
reviewed
Sep 1, 2022
...n/java/org/finos/legend/engine/generation/DataSpaceAnalyticsArtifactGenerationExtension.java
Outdated
Show resolved
Hide resolved
...n/java/org/finos/legend/engine/generation/DataSpaceAnalyticsArtifactGenerationExtension.java
Show resolved
Hide resolved
.../finos/legend/engine/language/pure/dsl/generation/extension/ArtifactGenerationExtension.java
Outdated
Show resolved
Hide resolved
.../finos/legend/engine/language/pure/dsl/generation/extension/ArtifactGenerationExtension.java
Outdated
Show resolved
Hide resolved
epsstan
requested changes
Sep 2, 2022
...n/java/org/finos/legend/engine/generation/DataSpaceAnalyticsArtifactGenerationExtension.java
Outdated
Show resolved
Hide resolved
...n/src/test/java/org/finos/legend/engine/extensions/collection/generation/TestExtensions.java
Outdated
Show resolved
Hide resolved
...n/java/org/finos/legend/engine/generation/DataSpaceAnalyticsArtifactGenerationExtension.java
Outdated
Show resolved
Hide resolved
...va/org/finos/legend/engine/generation/TestDataSpaceAnalyticsArtifactGenerationExtension.java
Outdated
Show resolved
Hide resolved
MauricioUyaguari
force-pushed
the
updateExtension
branch
2 times, most recently
from
036b7c6
to
d78d6e8
Compare
akphi
approved these changes
Sep 9, 2022
akphi
approved these changes
Sep 10, 2022
epsstan
approved these changes
Sep 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancement
What does this PR do / why is it needed ?
Which issue(s) this PR fixes:
Related to finos/legend-sdlc#504