Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema support in relation accessor #3256

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

rafaelbey
Copy link
Contributor

What type of PR is this?

Bug Fix

What does this PR do / why is it needed ?

Fix how schema looks ups are done on relation accessor. The code currently assumes the first schema on the DB was is the "default" schema. This fix explicitly uses schema named "default". This also improve completions to look into default schema, and also suggest schema names.

Which issue(s) this PR fixes:

Fixes #

Other notes for reviewers:

Does this PR introduce a user-facing change?

@rafaelbey rafaelbey requested a review from a team as a code owner November 19, 2024 02:54
Copy link

github-actions bot commented Nov 19, 2024

Test Results

  1 015 files  ±0    1 015 suites  ±0   1h 43m 5s ⏱️ + 3m 15s
12 725 tests ±0  12 600 ✔️ ±0  125 💤 ±0  0 ±0 
18 717 runs  ±0  18 592 ✔️ ±0  125 💤 ±0  0 ±0 

Results for commit 01d7500. ± Comparison against base commit e9c5379.

♻️ This comment has been updated with latest results.

@rafaelbey rafaelbey merged commit 028987c into finos:master Nov 19, 2024
6 checks passed
@rafaelbey rafaelbey deleted the schemaSupportRelation branch November 19, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants