Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set localResourceRoots in webview options to allow using local forms file #162

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

travisstebbins
Copy link
Contributor

@travisstebbins travisstebbins commented Feb 5, 2025

What type of PR is this?

Bug Fix

What does this PR do / why is it needed ?

This PR adds the studio forms file directory to the webview options localResourceRoots property so that the webview has permission to load a script from the user's local file system. Without this option, VSCode doesn't allow a webview to load something from the user's local file system for security reasons.

Which issue(s) this PR fixes:

Fixes #

Other notes for reviewers:

Does this PR introduce a user-facing change?

No

Opening Webviews works when a form file is set in the settings and when no form file is set:
OpeningWebviews

@travisstebbins travisstebbins marked this pull request as ready for review February 6, 2025 15:42
@travisstebbins travisstebbins requested a review from a team as a code owner February 6, 2025 15:42
@rafaelbey rafaelbey merged commit 2d0d6a4 into finos:main Feb 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants