Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for QueryBuilder light mode #145

Merged
merged 10 commits into from
Jan 23, 2025

Conversation

travisstebbins
Copy link
Contributor

@travisstebbins travisstebbins commented Jan 17, 2025

What type of PR is this?

Improvement

What does this PR do / why is it needed ?

This PR will render QueryBuilder in light mode if the user's VS Code theme is light. If the user's VS Code theme is dark then it will render QueryBuilder in dark mode.

Which issue(s) this PR fixes:

Fixes #

Other notes for reviewers:

Does this PR introduce a user-facing change?

Yes

QueryBuilder in dark/light mode:
QueryBuilderLightMode

@travisstebbins
Copy link
Contributor Author

Depends on finos/legend-studio#3818

@travisstebbins travisstebbins force-pushed the querybuilder-light-mode branch from 0f66c04 to c8d6416 Compare January 22, 2025 23:00
@travisstebbins travisstebbins marked this pull request as ready for review January 23, 2025 14:51
@travisstebbins travisstebbins requested a review from a team as a code owner January 23, 2025 14:51
@rafaelbey rafaelbey merged commit a3ffda6 into finos:main Jan 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants