Publish to NPM and export ComponentRouter with presets/plugins props #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisstebbins
force-pushed
the
publish-to-npm
branch
10 times, most recently
from
74ec6b6 to
deb6595
Compare
travisstebbins
force-pushed
the
publish-to-npm
branch
from
aaee040 to
8513f69
Compare
rafaelbey
reviewed
Jan 21, 2025
rafaelbey
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Improvement
What does this PR do / why is it needed ?
This PR refactors the extension codebase into a monorepo consisting of 3 separate packages:
This is the same structure as was introduced in #137, just separated into separate packages now instead of all in one package.
Refactoring the project now allows us to publish the code in the
clientpackage to npm, which this PR also accomplishes.These changes make plugging in a custom
WebViewRootscript into the extension easier and more modular by exporting theComponentRoutercomponent and addingpresetsandpluginsprops to it.This will allow custom
WebViewRootimplementations to simply import theComponentRouterprop that is published to npm and then pass in any additional presets/plugins they need to theComponentRouter, allowing much more code re-use instead of having to write all new code for theWebViewRoot.Which issue(s) this PR fixes:
Fixes #
Other notes for reviewers:
Does this PR introduce a user-facing change?
No