Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move dev dependencies to the right section #756

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

06kellyjac
Copy link
Contributor

Move some dependencies which are only used in dev.
Can't move concurrently because it's used by git-proxy-all at runtime.

λ git branch | grep '*'
* main
λ npm install --omit=dev
npm warn deprecated [email protected]: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm warn deprecated @material-ui/[email protected]: Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5.
npm warn deprecated @material-ui/[email protected]: Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5.

> @finos/[email protected] prepare
> node ./scripts/prepare.js


added 588 packages, and audited 590 packages in 26s

79 packages are looking for funding
  run `npm fund` for details

λ rm -rf node_modules
λ git checkout move_dependencies
Switched to branch 'move_dependencies'
λ npm install --omit=dev
npm warn deprecated [email protected]: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm warn deprecated @material-ui/[email protected]: Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5.
npm warn deprecated @material-ui/[email protected]: Material UI v4 doesn't receive active development since September 2021. See the guide https://mui.com/material-ui/migration/migration-v4/ to upgrade to v5.

> @finos/[email protected] prepare
> node ./scripts/prepare.js


added 415 packages, and audited 417 packages in 10s

52 packages are looking for funding
  run `npm fund` for details

Can't move concurrently because it's used by git-proxy-all at runtime
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 38d69f5
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/6718f26e10c2d50008c29ab0

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.08%. Comparing base (0b1bc4a) to head (38d69f5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #756   +/-   ##
=======================================
  Coverage   60.08%   60.08%           
=======================================
  Files          46       46           
  Lines        1631     1631           
=======================================
  Hits          980      980           
  Misses        651      651           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieSlome
Copy link
Member

LGTM 🍰

@JamieSlome JamieSlome merged commit 27e885c into finos:main Oct 23, 2024
14 checks passed
@06kellyjac 06kellyjac deleted the move_dependencies branch October 28, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants