Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dont leak password from server #741

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

lwhiteley
Copy link
Contributor

Remove all places where passwords are returned in user objects or logged to console

Copy link

netlify bot commented Oct 6, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit eecd5ce
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/670d35b830627e00088f3793

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.79%. Comparing base (ce03d71) to head (eecd5ce).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
+ Coverage   57.34%   57.79%   +0.45%     
==========================================
  Files          46       46              
  Lines        1594     1597       +3     
==========================================
+ Hits          914      923       +9     
+ Misses        680      674       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lwhiteley lwhiteley force-pushed the dont-leak-password branch 3 times, most recently from b844b4c to b27574f Compare October 7, 2024 05:35
Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit a1d8f42 into finos:main Oct 14, 2024
14 checks passed
@lwhiteley lwhiteley deleted the dont-leak-password branch October 14, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants