chore: dont leak password from server #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #741 +/- ##
==========================================
+ Coverage 57.34% 57.79% +0.45%
==========================================
Files 46 46
Lines 1594 1597 +3
==========================================
+ Hits 914 923 +9
+ Misses 680 674 -6 ☔ View full report in Codecov by Sentry. |
lwhiteley
force-pushed
the
dont-leak-password
branch
3 times, most recently
from
b844b4c
to
b27574f
Compare
lwhiteley
force-pushed
the
dont-leak-password
branch
from
b27574f
to
0d9491d
Compare
JamieSlome
reviewed
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all places where passwords are returned in user objects or logged to console