-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Releaser #534
Releaser #534
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #534 +/- ##
=======================================
Coverage 56.96% 56.96%
=======================================
Files 46 46
Lines 1566 1566
=======================================
Hits 892 892
Misses 674 674 ☔ View full report in Codecov by Sentry. |
looks good to me @eddie-knight , thank you! Is it ok if you show us a test release during the next meeting on May 6th ? Feel free to also invite your colleagues at Sonatype, so we can get immediate feedback. @JamieSlome - could you please have a look at this PR please? TY! |
Signed-off-by: Eddie Knight <[email protected]>
Signed-off-by: Eddie Knight <[email protected]>
@eddie-knight - awesome PR, thank you 🎉 What do we need to do to close this off and merge? |
@JamieSlome It'll be important to note that once this is merged, all future PRs will have a new check running to validate that their title begins with one of the accepted terms. Then, it'll be important that anyone merging PRs is aware of the implications of the title— a major, minor, or patch release will be made upon every PR merge following this one. I'll take the PR out of draft mode and I can present it on Monday's call if you want, or you can merge it at your leisure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍰
This will resolves #532.