Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile Git Proxy with most up-to-date improvements #335

Merged
merged 169 commits into from
May 1, 2024
Merged

Conversation

JamieSlome
Copy link
Member

@JamieSlome JamieSlome commented Oct 31, 2023

@JamieSlome JamieSlome added the enhancement New feature or request label Oct 31, 2023
@JamieSlome JamieSlome requested a review from maoo October 31, 2023 11:56
@JamieSlome JamieSlome self-assigned this Oct 31, 2023
@netlify
Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 248e5f8
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/66321ac3182a880008ac51b2

@maoo
Copy link
Member

maoo commented Oct 31, 2023

This is great, thanks @JamieSlome !

I looked at the diff, it seems that all changes apply to dashboard and testing, is that correct?

On top of the quickstart instructions, what are the steps to run the UI? I'd be happy to help testing/reviewing here.

@JamieSlome
Copy link
Member Author

This is great, thanks @JamieSlome !

I looked at the diff, it seems that all changes apply to dashboard and testing, is that correct?

On top of the quickstart instructions, what are the steps to run the UI? I'd be happy to help testing/reviewing here.

Added you as a reviewer slightly too early @maoo! Still lots of changes to come 👍

@JamieSlome JamieSlome removed the request for review from maoo April 19, 2024 10:30
@JamieSlome
Copy link
Member Author

JamieSlome commented May 1, 2024

@maoo @coopernetes @msagi - this PR is now ready to go 🚀

I have set CSRF protections as enabled by default in proxy.config.json. This can be turned off using the csrfProtection flag for anyone not interested in using the user interface (as CSRF is specifically a browser exploitable vulnerability).

I am happy to merge now and work on bug fixes as patch releases after the fact. A bit stumped by testing the two new bin commands with npx prior to merge. Any thoughts?

To the side of this I will bump the version to v1.2.0 and merge 👍

@JamieSlome JamieSlome merged commit 00bc7ea into main May 1, 2024
13 checks passed
@JamieSlome JamieSlome deleted the reconcile branch June 19, 2024 12:22
@JamieSlome JamieSlome restored the reconcile branch June 19, 2024 12:22
@JamieSlome JamieSlome deleted the reconcile branch June 19, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconcile changes on mvp branch with main
4 participants