Create CVE Scanning #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
=======================================
Coverage 77.74% 77.74%
=======================================
Files 49 49
Lines 391 391
Branches 37 37
=======================================
Hits 304 304
Misses 73 73
Partials 14 14 ☔ View full report in Codecov by Sentry. |
bingenito
approved these changes
Dec 12, 2023
|
@josspo I think it is trying to interpret some dependency as being node/npm dependencies and reporting CVEs. https://github.com/morganstanley/fdc3-dotnet/actions/runs/7184323366 |
|
@bingenito Are the CVEs false positives? If so, I can add them to the allow-list.xml. |
|
@josspo I have to look at the nuget one still, but for the others it seems to think that "MorganStanley.Fdc3.Newtonsoft.Json" and "MorganStanley.Fdc3.Newtonsoft.Json.Tests" are the morgan-json and other releted npm packages which is absolutely a false positive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVE Scanning action that use DependencyCheck with allow-list.xml.
Enable
<EnableWindowsTargeting>true</EnableWindowsTargeting>in WpfFdc3.csproj because the action was failing if it's set to false.