-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/#689 CLI Server #877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking really good for a v1 - if we decide to keep health
endpoint it should move to root so that when we introduce a proper health check framework ( like terminus ) they're using the same URLs
Ross does not have time to review and this is a second pass. All topics raised in the pass he made have been answered
Adding in a first iteration of the CLI as a server for issue #689