Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/#689 CLI Server #877

Merged
merged 15 commits into from
Feb 6, 2025
Merged

Features/#689 CLI Server #877

merged 15 commits into from
Feb 6, 2025

Conversation

Budlee
Copy link
Member

@Budlee Budlee commented Jan 29, 2025

Adding in a first iteration of the CLI as a server for issue #689

@Budlee Budlee marked this pull request as ready for review January 30, 2025 16:32
Thels
Thels previously requested changes Jan 31, 2025
Copy link
Member

@Thels Thels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking really good for a v1 - if we decide to keep health endpoint it should move to root so that when we introduce a proper health check framework ( like terminus ) they're using the same URLs

willosborne
willosborne previously approved these changes Jan 31, 2025
@Budlee Budlee dismissed Thels’s stale review February 6, 2025 14:57

Ross does not have time to review and this is a second pass. All topics raised in the pass he made have been answered

@Budlee Budlee merged commit 7918628 into finos:main Feb 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants