libiconv updates #939
libiconv updates #939
Conversation
dmacks
commented
Jan 9, 2023
•
dmacks
commented
- Fix for new platforms that don't have /usr/bin/groff
- Should we just BDep:gperf (made Essential:true) rather than rolling our own? It has no deps of its own.
- New upstream version
|
I'm fine with whatever is needed to fix the loss of groff, but I'm at a loss to understand how removing an HTML tag fixes that. Just trying to understand is all. |
|
The groff tool is part of the Makefile recipes for generating man/iconv.1.html from man/iconv.1, but the source tarball has a pregenerated html file. We have a long-standing patch segment that changes iconv.1, so make sees the newer timestamp on that source file and runs groff to regenerate iconv.1.html. So I changed the .patch to also include the resulting change in .1.html and therefore not need to have groff available. It's possible our PatchScript may need to |
|
gperf-3.2 is noted as released upstream for over a year now, but they never actually released it? https://savannah.gnu.org/bugs/index.php?62139 So if anyone has build problems on newer platforms, there might be relevant fixes upstream. |
|
Confirmed this fixes libiconv build on 13.x (arm and x86_64) |
|
please add to bootstrap once approved so I can pull this into my PR please |
|
@nieder I'm going to cherry-pick the groff part into bootstrap and main ASAP. Any objection to the gperf going as well? Want a second opinion because it makes another package Essential:true. |
|
I did it with pref as essential in bootstrap when I tested. It's fairly small didn't add much time at all. And honestly anytime to can link to a fink build dev I believe we should. Makes us more future proof |
dmacks
force-pushed
the
libiconv-update
branch
from
70471f7
to
f76453f
Compare
|
Sorry about the noise, just re-jiggering the commits and fixing some details so I can cherry-pick. |
|
still looks good, did you want me, want me to retest? and if so did you want me to retest without pref since I didn't do that? |
|
I think this can be closed now, libiconv is fixed and committed |
|
OH I see it's left open for an update, nvm I missed that |
