Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passwd Refactor #1031

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Passwd Refactor #1031

wants to merge 8 commits into from

Conversation

dak180
Copy link
Member

@dak180 dak180 commented May 29, 2023 •
edited
Loading

@dak180 dak180 added the new upstream Package has an updated upstream version label May 29, 2023
@dak180 dak180 requested a review from a team May 29, 2023 16:37
@TheSin-
Copy link
Member

TheSin- commented Jul 11, 2023

passwd-core can not be installed as the split needs .md added to both DocFiles

@TheSin-
Copy link
Member

TheSin- commented Jul 11, 2023

to get this working, you'll need the tarball from fink/passwd#6 and rename it to passwd-20230529.tgz, this modify the passwd-core.info for the SourceDirectory from passwd-%v to passwd-20160421 (after you fix the split off DocFiles)

This will allow it to be installed for testing.

@dak180 dak180 mentioned this pull request Jul 17, 2023
Merged
2 tasks
TheSin-
TheSin- previously approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@TheSin- TheSin- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once fink/passwd#6 is committed we should committed this as well.

@dak180 dak180 marked this pull request as ready for review July 18, 2023 13:59
@dak180 dak180 requested review from a team July 18, 2023 14:00
@dak180 dak180 requested review from TheSin-, nieder and dmacks July 18, 2023 17:28
@dak180 dak180 mentioned this pull request Aug 4, 2023
Open
@dak180 dak180 mentioned this pull request Sep 15, 2023
Open
@kristibektashi
Copy link

once fink/passwd#6 is committed we should committed this as well.

So fink/passwd#6 has been merged, so what happens with this PR?

@dak180
Copy link
Member Author

dak180 commented Oct 2, 2023

So fink/passwd#6 has been merged, so what happens with this PR?

Waiting for someone on the @fink/fink-developers or @fink/package-maintainers (besides myself) to get enough free cycles to review and pass; it is a busy time of year.

@cooljeanius
Copy link

So fink/passwd#6 has been merged, so what happens with this PR?

Waiting for someone on the @fink/fink-developers or @fink/package-maintainers (besides myself) to get enough free cycles to review and pass; it is a busy time of year.

besides the 2 groups you listed, this PR also has @nieder @dmacks @TheSin- and @fink/core listed as pending reviewers...

@dak180
Copy link
Member Author

dak180 commented Aug 14, 2024

@cooljeanius just waiting for anyone to test it to ensure that it works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooljeanius cooljeanius cooljeanius approved these changes

@TheSin- TheSin- Awaiting requested review from TheSin-

@nieder nieder Awaiting requested review from nieder

@dmacks dmacks Awaiting requested review from dmacks

At least 1 approving review is required to merge this pull request.

Assignees

@nieder nieder

@dmacks dmacks

Labels
new upstream Package has an updated upstream version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dak180 @TheSin- @kristibektashi @cooljeanius @nieder @dmacks