Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error on regexp for ingress endpoint query parameters #49

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

Orkuncakilkaya
Copy link
Contributor

This fixes the problem about duplication of query parameters to be replaced.

Tested this regular expression with these values:

/__integration_path__/__result_path__/hello/world?query=123
/__integration_path__/__result_path__/?query=123
/__integration_path__/__result_path__?query=123
/__integration_path__/__result_path__
/__integration_path__/__result_path__/hello
/__integration_path__/__result_path__/hello/world
/__integration_path__/__result_path__/hello?query=123
/__integration_path__/__result_path__/hello/world/?query=123

Result was:

/?ii=fingerprint-pro-akamai/{{user.PMUSER_FPJS_INTEGRATION_VERSION}}/ingress&{{builtin.AK_QUERY}}
/?ii=fingerprint-pro-akamai/{{user.PMUSER_FPJS_INTEGRATION_VERSION}}/ingress&{{builtin.AK_QUERY}}
/?ii=fingerprint-pro-akamai/{{user.PMUSER_FPJS_INTEGRATION_VERSION}}/ingress&{{builtin.AK_QUERY}}
/?ii=fingerprint-pro-akamai/{{user.PMUSER_FPJS_INTEGRATION_VERSION}}/ingress&{{builtin.AK_QUERY}}
/?ii=fingerprint-pro-akamai/{{user.PMUSER_FPJS_INTEGRATION_VERSION}}/ingress&{{builtin.AK_QUERY}}
/?ii=fingerprint-pro-akamai/{{user.PMUSER_FPJS_INTEGRATION_VERSION}}/ingress&{{builtin.AK_QUERY}}
/?ii=fingerprint-pro-akamai/{{user.PMUSER_FPJS_INTEGRATION_VERSION}}/ingress&{{builtin.AK_QUERY}}
/?ii=fingerprint-pro-akamai/{{user.PMUSER_FPJS_INTEGRATION_VERSION}}/ingress&{{builtin.AK_QUERY}}

@necipallef
Copy link
Contributor

Let's talk about only
/__integration_path__/__result_path__/hello/world/?query=123
and its result which is
/?ii=fingerprint-pro-akamai/{{user.PMUSER_FPJS_INTEGRATION_VERSION}}/ingress&{{builtin.AK_QUERY}}
I think the result should be
/hello/world/?ii=fingerprint-pro-akamai/{{user.PMUSER_FPJS_INTEGRATION_VERSION}}/ingress&{{builtin.AK_QUERY}} because we should not lose the path.

Also, the same solution should be applied to the procdn request, too. Wdyt? @Orkuncakilkaya

Copy link

This PR will create a minor release 🚀

0.2.0 (2024-03-20)

Features

  • support passing custom api url during build (7571426)

Bug Fixes

  • error on regexp for ingress endpoint query parameters (efca297)

@Orkuncakilkaya Orkuncakilkaya merged commit b00704d into main Mar 21, 2024
5 checks passed
@Orkuncakilkaya Orkuncakilkaya deleted the fix/inter-591 branch March 21, 2024 09:12
@ilfa
Copy link
Member

ilfa commented Mar 21, 2024

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ilfa ilfa added the released label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants