ci(e2eForPRs): check for paths in runtime instead of using gh action builtin filtering #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…builtin filtering
necipallef
force-pushed
the
ci/improve_e2e_for_prs-INTER-417
branch
from
9797ed5 to
ff50747
Compare
This PR will not create a new release 🚀 |
Orkuncakilkaya
approved these changes
Nov 17, 2023
ilfa
approved these changes
Nov 17, 2023
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GH action I am using is outdated, uses deprecated GitHub methods, and uses node12. We can create a future task for ourselves to fork this action and fix its problems, if needed.
Edit: It seems like using 2 jobs doesn't solve our problem, the skipped job will still be a requirement for merge. If this is the case, I will merge these two jobs into one. I wanted to avoid repeating the if statement for each step of e2e test.