MAINT: Expand reshape testing
#120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsokol
force-pushed
the
reshape-update
branch
7 times, most recently
from
f58c0fb to
c593acd
Compare
|
I've spent today trying to debug macos HDF5 issue but without luck, let's keep it failing for now. I spent enough time debugging OpenSSL_jll dependency issue last time. I reported this issue and created a reproduction repo: JuliaIO/HDF5.jl#1198 Let's merge it now for a new |
mtsokol
force-pushed
the
reshape-update
branch
3 times, most recently
from
ec15aeb to
eaf57ee
Compare
|
In JuliaIO/HDF5.jl#1198 we found out how to fix macos job for now (pinned juliacall version). |
hameerabbasi
approved these changes
May 19, 2025
|
Thanks, @mtsokol! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of
finch-tensorwithout a performance regression.