Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/se 1119.add tests for term deposit #97

Merged
merged 3 commits into from
Apr 19, 2021

Conversation

lorenzdec
Copy link
Contributor

Pull Request Checklist

Description of the PR

Describe the code changes for the reviewers, explain the solution you have provided and how it fixes the issue

Copy link
Contributor

@jyaffe jyaffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good initial commit but a bit of cleanup is needed as well as further assertions within the test.

Please can you also update the PR description and checklist? It will help us quickly understand this PR if we need to come back and review it in the future.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@slemasne slemasne merged commit 6e7a38d into develop Apr 19, 2021
@jyaffe jyaffe deleted the feature/SE-1119.AddTestsForTermDeposit branch April 19, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants