Fixed issues with nested array functions being copied incorrectly #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ointing to the wrong function.
…n-issue Bugfix/nested array function issue
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 165 165
Branches 36 36
=========================================
Hits 165 165
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to fix related issues to #49 and #51
I am currently moving items around where two objects have different properties with the nested change, blur, focus functions. When they get moved, the function just gets deleted because it is trying to pull the function reference from the destination and not the source.
I fixed the tests that were making an incorrect assumption about what the function should be when an item is moved. If you move an item from 0 to 1 then the function now in spot 1 should be the function that was in spot 0 not what was in spot 1. See moveFieldState.js new comment for more details.