Add support for read receipts. #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipre
requested changes
May 29, 2024
| aiohttp.ClientError, | ||
| aiohttp.http_exceptions.HttpProcessingError, | ||
| ): | ||
| raise ReactionError |
There was a problem hiding this comment.
Should this be a reaction error?
| @@ -93,6 +93,26 @@ async def react( | |||
| ): | |||
| raise ReactionError | |||
|
|
|||
| async def receipt( | |||
| self, recipient: str, receipt_type: str, target_author: str, timestamp: int | |||
There was a problem hiding this comment.
It makes sense to introduce literals for parameters like receipt_type. I know it can take read as a value. What else?
| recipient = message.recipient() | ||
|
|
||
| # can't do groups yet because not supported in signal-cli | ||
| if getattr(message, 'group'): |
There was a problem hiding this comment.
This line fails the pre-commit hook
| @@ -150,6 +170,9 @@ def _react_rest_uri(self): | |||
| def _typing_indicator_uri(self): | |||
| return f"http://{self.signal_service}/v1/typing-indicator/{self.phone_number}" | |||
|
|
|||
| def _receipt_rest_uri(self): | |||
There was a problem hiding this comment.
to stay consistent with the methods, I'd call it _receipts_rest_uri instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read receipts for individual messages are available in bbernhard/signal-cli-rest-api#534. This adds support via
Context.receipt("read").