Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: python 3.9 does not support | syntax for union #52

Merged
merged 1 commit into from
May 4, 2024

Conversation

laurimi
Copy link

@laurimi laurimi commented Apr 28, 2024

Running the code on Python 3.9 gives the error:
TypeError: unsupported operand type(s) for |: 'types.GenericAlias' and 'type'

The fix is to use Union and Optional as is done elsewhere in the file.

@filipre
Copy link
Owner

filipre commented May 4, 2024

Thank you very much! Eventually, I'll drop support for Python 3.9 but if this is the only place right now, I'm fine with continuing supporting it.

@filipre filipre merged commit 4038975 into filipre:master May 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants