[WIP] expand python compatibility + dependencies clean up #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chemik-bit
force-pushed
the
more_python_compat
branch
from
a985794 to
c4b49ba
Compare
chemik-bit
force-pushed
the
more_python_compat
branch
from
c3b8a4d to
1146f21
Compare
chemik-bit
force-pushed
the
more_python_compat
branch
from
1146f21 to
9550649
Compare
chemik-bit
force-pushed
the
more_python_compat
branch
3 times, most recently
from
62152ba to
eac4a4e
Compare
chemik-bit
force-pushed
the
more_python_compat
branch
from
eac4a4e to
f67fc3d
Compare
chemik-bit
force-pushed
the
more_python_compat
branch
from
f2d6ac3 to
26b6cc5
Compare
filip-michalsky
commented
Dec 4, 2023
There was a problem hiding this comment.
Great work! To finish this up, we need to update the readme with precise installation instructions for dependencies using poetry please as well as addressing the additional comments in this PR. Thank you.
Also please rename unit tests in github workflow to english - ty!
chemik-bit
force-pushed
the
more_python_compat
branch
from
4bae3c5 to
c123ca8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is WIP
we want: