Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test #60

Closed
wants to merge 8 commits into from
Closed

Add test #60

wants to merge 8 commits into from

Conversation

Joshua-onwuzu
Copy link
Contributor

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.

nadeem-fileverse
nadeem-fileverse requested changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@nadeem-fileverse nadeem-fileverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

packages/heartbit-core/src/test/mockData.ts Outdated Show resolved Hide resolved
packages/heartbit-core/jest.config.cjs Show resolved Hide resolved
nadeem-fileverse
nadeem-fileverse requested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@nadeem-fileverse nadeem-fileverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

.github/workflows/test.yml
restore-keys: |
${{ runner.os }}-pnpm-
- name: 🧩 Install Dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build can be made from the root command i think check for build command in root package.json

.github/workflows/test.yml Outdated
run: pnpm run build
working-directory: ./packages/heartbit-core

- name: 🧪 Run Tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update for heartbit react

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadeem-fileverse nadeem-fileverse nadeem-fileverse requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Joshua-onwuzu @nadeem-fileverse